Gatsby: [site-showcase] filters should cause scroll-down

[calcsam]

Summary

URLs (and possibly interactions with filters) should cause the Site Showcase to scroll down past the "Featured" header

Basic example

Eg: https://www.gatsbyjs.org/showcase/?filters%5B0%5D=Bank should load here:

instead of here:

Motivation

This will allow filter settings such as personal sites, blogs, e-commerce, etc, to be more easily linkable and usable from other parts of the site and externally.

cc @gatsbyjs/ecosystem

[MikeBudimon]

I would like to work on this issue.

[fk]

👌🙏 Go for it Mike!

Am 12.10.2018 um 14:53 schrieb Michal Wagner [e-mail]:

I would like to work on this issue.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[gatsbot[bot]]

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

[amberleyromo]

@MikeBudimon any interest in still working on this?

[MikeBudimon]

@amberleyromo yeah I am still intrested.
Next week I could work on issue #11001 to unblock this issue and then work on this one.

[github-actions[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[github-actions[bot]]

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

[wardpeet]

It would be great if this can get fixed :smile::. For anyone who wants to, here are some pointers that I think need to be done. Feel free to ignore and do it differently 😄.

What needs to be done?:
We should not trigger the scrollToAnchor code when the list of items is empty

What I think needs to be done:
We load the filtered-list in
https://github.com/gatsbyjs/gatsby/blob/c591eb774ba355543a2be7d529701cfa5bb56b5f/www/src/views/showcase/index.js#L65-L69

The data here is the unfiltered list, and filtering is done inside the filtered-list component. The filtering is done here:
https://github.com/gatsbyjs/gatsby/blob/c591eb774ba355543a2be7d529701cfa5bb56b5f/www/src/views/showcase/filtered-showcase.js#L80-L82

We need to lift this code out of the filtered-showcase component into the showcase/index.js file. When the filtering logic is inside the index.js file we can use it to trigger or not trigger the scrolling behavior defined in:
https://github.com/gatsbyjs/gatsby/blob/c591eb774ba355543a2be7d529701cfa5bb56b5f/www/src/views/showcase/index.js#L44

[rbelow]

Hello everyone! Thanks for the cool work at Gatsby. I checked the behavior of the _Showcase_ filter with: https://www.gatsbyjs.org/showcase/?filters%5B0%5D=Design - and it seems to scroll to the correct position (it shows the _Design_ cases). Maybe I have misinterpreted the description. Is this still an issue, @wardpeet ? Are you working on it, @MikeBudimon ?

[LekoArts]

Yeah, seems to be fixed!