Gatsby: [www/showcase] Make site detail modal responsive

Created on 25 Jul 2018  Β·  12Comments  Β·  Source: gatsbyjs/gatsby

Currently the details modal shown for window widths 750px and larger is hardcoded to that same width of 750px: https://github.com/gatsbyjs/gatsby/blob/49c52f5e78d56083a0cb45e8cd9306fcd0b92de4/www/src/components/layout.js#L74-L94

This means when reducing the window width below 750px, the modal content won't adapt to the screen width, resulting in first links to the next and previous sites to be cut off, and finally the modal content itself.

Let's fix that!

Hacktoberfest

Most helpful comment

Hi, I saw this hanging out here and thought I'd take a stab at it.

All 12 comments

At narrower viewport, we could place the prev and next sites _under_ the featured site. I can take this. Are we drawing the line at flexbox or can we use grid?

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

We still want to do this! ✌️

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

πŸ€”hello, is this thing on? can I have a go at this? is there a design? for it?

Hey @riencoertjens! I'm not aware of any design, if you'd like to work on it feel free to make a PR perhaps implementing the suggestion above to add the next/prev links below the site. In response to @ryanditjia's question about flexbox/grid we're happy to use either or whatever makes sense!

I'll mark this as Hacktoberfest - Claimed, if you are unsure of what you've got, feel free to post a screenshot or a link to your PR or branch and someone can take a look at it too to keep all the design consistent with other elements on the site πŸ™‚

@riencoertjens Are you working on this? Need some help?

I'm sorry I got a sudden flood of work right before I wanted to tackle this... Hoping to do it this weekend

@Italox if you want you can go ahead and do this, unfortunately I won't have time for it.

Hi, I saw this hanging out here and thought I'd take a stab at it.

Fixed in #18956 by @brockduncan!
Thanks everybody! πŸ™

(Oh … and hey @riencoertjens :( πŸ™)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ferMartz picture ferMartz  Β·  3Comments

dustinhorton picture dustinhorton  Β·  3Comments

3CordGuy picture 3CordGuy  Β·  3Comments

timbrandin picture timbrandin  Β·  3Comments

rossPatton picture rossPatton  Β·  3Comments