Gatsby: Refactor code from site showcase into components

Created on 24 Jul 2018  路  9Comments  路  Source: gatsbyjs/gatsby

Make any reusable parts of the site showcase into components. I believe Shawn and @kkemple already started this.

This will be important for polishing the starter showcase and also helping with the Gatsby agency pages @berraknil is working on.

stale?

All 9 comments

I refactored a couple of things in #6838 but held off from doing more because I was worried about doing so making it potentially harder for @sw-yx to merge stuff back into his PR for the starter showcase (#6113).

Maybe it's easier to merge Shawn's current version of the PR and then refactor?

/cc @calcsam @KyleAMathews @sw-yx

it sounds like this project has been moved to backlog so i'll wait for further instructions on this if i am to proceed. sorry i have never meant to be a blocker on your work.

unassigning @fk since he's got a lot on his plate, also unassigning @kkemple since he's on other things.

@berraknil @fk could we list components that could be shared, and if so should be refactored, here so we have a clear scope for this ticket? I know Card was a big one we discussed.

After you do that, we can discuss what makes sense.

@calcsam I don鈥檛 know how much (if any) of the components will be needed in the pages I am designing. I suggested the card component as an idea, because @fk asked at the meet谋ng, but I might end up creating a new one depending on the necessities.

I am currently working on wireframes and design of the new pages as we agreed so not really in a place to refactor these components myself, as I haven鈥檛 even worked on the original code.

This is not a blocker for me or urgent in my case as I will probably end up writing new components anyway.

Agreed. Main goal here is to get a list of the things that _should_ or _could_ be extracted out so we can scope this ticket appropriately. It definitely belongs in a different project than yours @berraknil.

Sure, it seemed that there are already some components that are used in both starter showcase and site showcase (?) in our meeting, so I didn't want to be a blocker on refactoring of those with my possible list of components.

If I end up using one of the available ones, good, but I might not use any of them, so just wanted to clarify that to not block the work on this.

Starting a list here for future reference,

  • [ ] The Search component, shared between main page, showcase and on creators/community pages so far as well. I pretty much copy pasted most of the current animation and styling from there, so probably can be abstracted to an external shared component.

image

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

This issue is being closed due to inactivity. Is this a mistake? Please re-open this issue or create a new issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

signalwerk picture signalwerk  路  3Comments

hobochild picture hobochild  路  3Comments

andykais picture andykais  路  3Comments

ghost picture ghost  路  3Comments

KyleAMathews picture KyleAMathews  路  3Comments