Gatsby: [gatsby-remark-catch-link] doesn't redirect properly if someone links to a full URL on the same site

Created on 23 Jul 2018  路  7Comments  路  Source: gatsbyjs/gatsby

If you visit the site showcase blog post at https://next.gatsbyjs.org/blog/2018-07-20-why-we-built-the-site-showcase/ and try to click on the showcase link, it doesn't work. We should update gatsby-remark-catch-links so it can handle full URLs pointing to the same domain correctly.

good first issue help wanted

Most helpful comment

I will take this on @KyleAMathews

All 7 comments

I will take this on @KyleAMathews

Thanks @kylegreene!

@KyleAMathews this thread has been inactive for some days, so I went ahead and pushed a PR. Please review.

@KyleAMathews @shobhitchittora @kylegreene

I am still having this issue on the latest beta version of Gatsby and gatsby-plugin-catch-links. The internal links from the tableOfContents field in my markdownRemark queries do not get intercepted and are broken.

Should we reopen this issue, or should I file a new one?

Never mind, looks like it got fixed in #6990

Found a similar issue in Gatsby docs https://www.gatsbyjs.org/docs/gatsby-cli/#gatsby-cli The Gatsby Starters link renders a 404 page. The original link specified is https://www.gatsbyjs.org/docs/gatsby-starters/ while the same entered in browser redirects to https://www.gatsbyjs.org/starters/?v=2

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ferMartz picture ferMartz  路  3Comments

brandonmp picture brandonmp  路  3Comments

Oppenheimer1 picture Oppenheimer1  路  3Comments

theduke picture theduke  路  3Comments

signalwerk picture signalwerk  路  3Comments