Gatsby-theme-novela: Contributing: Disqus, Image Zooming
Amazing work on the plugin, seriously. I was able to integrate this into my site in a couple hours, customizations and all. There were a couple missing features I was able to add thanks to Component Shadowing and would be happy to make a PR for them if you're interested in bringing them into the library.
Disqus comments
Gatsby already has a plugin for this and the component could be conditionally rendered if the user passes the config object in. Here's what it looks like in my app after a little styling:
Image Zooming
I like to zoom in photos when I read them and there's a nifty React library that does all the magic for you. I have it turned on in my app to replace all img tags with that component in the MDX.
I also noticed that when you create the URLs for title that have an apostrophe in there it kebabs between them. Maybe that's expected functionality.
https://www.calderadigital.com/blog/the-non-techie-s-guide-to-creating-a-successful-app
Thank you again! If you'd like for me to PR the two features I added let me know how I can run everything locally. If not, all good! Here's a link to the website if you want to test them in action.
mwood23
All 4 comments
Wow! I love the site. I've shared it with our team and we're all really impressed.
I'll take a look through the examples. Right now Image Zooming looks really appealing. There's quite a bit I want to do with images within articles and zoom feels like a great addition.
As for Disqus, I think it would be great to have an option or component you can add to your site and it automatically integrates nicely.
ps: you make also want to check out latest version of Novela. There's quite a bit refactored under the hood with the same look and feel. and I hope it's a seamless transition for you. If not, feel free to reach out and we'll work together to solve it.
brotzky
on 8 Aug 2019
Whoa, this is amazing! I love how nicely everything integrates with your existing brand, too.
Thanks for the great suggestions, both Image Zooming and Disqus are 馃憣
Nice job!
tcostaco
on 8 Aug 2019
Image zooming in next release: https://github.com/narative/gatsby-theme-novela/pull/36
Disqus still needs more consideration. Looking at a possible config option. Don't think we will build it into core.
brotzky
on 9 Aug 2019
Another alternative to disqus https://staticman.net
chakrihacker
on 15 Aug 2019
Related issues
dennismorello
路
4Comments
KrisBraun
路
4Comments
mabasic
路
4Comments
SabariVig
路
4Comments
bravo-kernel
路
4Comments
Most helpful comment
Wow! I love the site. I've shared it with our team and we're all really impressed.
I'll take a look through the examples. Right now Image Zooming looks really appealing. There's quite a bit I want to do with images within articles and zoom feels like a great addition.
As for Disqus, I think it would be great to have an option or component you can add to your site and it automatically integrates nicely.
ps: you make also want to check out latest version of Novela. There's quite a bit refactored under the hood with the same look and feel. and I hope it's a seamless transition for you. If not, feel free to reach out and we'll work together to solve it.