Gatsby-theme-novela: [proposal] optional hero images

Created on 7 Aug 2019  路  3Comments  路  Source: narative/gatsby-theme-novela

i hit a hard stop on my time spent trying and failing to shadow things (as per #28) to remove the image dependency in user land 馃槄 have to fix in the theme itself.

here is my proposal for optional images:

  • user passes in a theme option like optionalImages: true
  • if optionalImages: true, then on the main page, no images are shown, just titles and text. this keeps the design somewhat consistent.
  • on the article page, if there is an image, show it, if not, just hide it. easy.

ofc this is adding api surface area you may not want to maintain so i totally respect if you turn this down. just noting that i will have to stop here since i do not want images on every article.

Most helpful comment

totally get you. please stick to your vision, dont mind me.

All 3 comments

I discussed this with @tcostaco and he said without images the design would have to be re-done. So, for this theme, we don't think it would be realistic to add an optionalImage option at this time -- it compromises design too much.

Something we have spoken about internally creating a simpler blog that's as refined as Novela but without the need for images. Maybe that's in the form of shadowing and paramters or maybe that's another theme that sits within the @narative family. Right now our hands are quite full but it's if there's overwhelming demand we may jump on it quicker.

totally get you. please stick to your vision, dont mind me.

In case anyone stumbles upon this via Google, follow this feature here: https://github.com/narative/gatsby-theme-novela/issues/43

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jorgeorejas picture jorgeorejas  路  3Comments

KrisBraun picture KrisBraun  路  4Comments

eugenejeonme picture eugenejeonme  路  3Comments

brotzky picture brotzky  路  4Comments

mabasic picture mabasic  路  4Comments