Gatsby-source-wordpress-experimental: Issue with image links with special character

[patrikarvidsson]

I'm having issues downloading some images from a fairly long-running (Swedish) Wordpress site.

We are using WP Offload Media and uploading images to AWS/DO buckets, where a _working link_ is generated as file url. Although this plugin seems to fetch another URL instead.

Original filename
nyttigt-mellanmål_proteinkakor.jpg

WP Offload Media
nyttigt-mellanma%CC%8Al_proteinkakor.jpg

Source plugin
nyttigt-mellanma%25CC%258Al_proteinkakor.jpg

There are quite a few occurrences with åäö and it seems that something is up with the encoding translation. I'm not sure what we can do about it (I haven't encountered a lot of this stuff before), but maybe some light can be shed on the issue here.

EDIT:

As pointed out by @chip2n, it seems that decoding nyttigt-mellanma%25CC%258Al_proteinkakor.jpg twice results in nyttigt-mellanmål_proteinkakor.jpg. Could it be that something happened when fixing #7 ?

[TylerBarnes]

@patrikarvidsson , it could be indeed. Perhaps WPGraphQL is handling this in later versions. Are you able to share your /graphql api url so I can easily reproduce this? Or is it enough for me to upload an image with nyttigt-mellanmål_proteinkakor.jpg as a filename?

I'll get this fixed asap and add a test for this to prevent future regressions.

Thanks!

[patrikarvidsson]

@TylerBarnes No problems. I'll send you a mail at your [email protected]. There are more than this occurrence so you might benefit from the actual api for testing.

[TylerBarnes]

This is fixed in [email protected]! Needed to check if the URL was already encoded before attempting to encode it. Your build still isn't succeeding because you have some images that legitimately 404. Once you update and run a build you should see errors about those. For now the build can't succeed past 404's so you'll have to fix those. Follow #70 if you're interested in allowing 404's.

Thanks for opening this issue and for providing a reproduction!

Cheers

[TylerBarnes]

PS 404 images no longer fail the build in develop 🙌

[patrikarvidsson]

PS 404 images no longer fail the build in develop 🙌

Fantastic! Thank you so much for looking into this so quickly!