Galacticraft: [1.8.9] Oxygen Sealer Ambient Thermal Controller not working

Created on 31 Jan 2017  路  13Comments  路  Source: micdoodle8/Galacticraft

Issue mainly for @micdoodle8:
The Oxygen Sealer Thermal Controller is not working, by this i mean it shows N/A when adding the Ambient Thermal Controller, it should be showing "ON" yet i still dont take thermal damage though. Which makes the use of the thermal thing for Oxygen Sealers not working for 1.8.9. I tested with 1.7.10 and it was working there.....

I found this out when using the function below that is in the OxygenUtil within my addon, and its returning false when i should be getting a true when using the setup that is explained above :P

public static boolean isAABBInBreathableAirBlock(World world, AxisAlignedBB bb, boolean testThermal)
    {
        final double avgX = (bb.minX + bb.maxX) / 2.0D;
        final double avgY = (bb.minY + bb.maxY) / 2.0D;
        final double avgZ = (bb.minZ + bb.maxZ) / 2.0D;

        if (testThermal)
        {
            return OxygenUtil.isInOxygenAndThermalBlock(world, bb.contract(0.001D, 0.001D, 0.001D));
        }

        if (OxygenUtil.inOxygenBubble(world, avgX, avgY, avgZ))
        {
            return true;
        }

        return OxygenUtil.isInOxygenBlock(world, bb.contract(0.001D, 0.001D, 0.001D));
    }
1.8+

All 13 comments

Any idea what is causing this issue @radfast / @micdoodle8

I'll look at this the next time I have this code loaded, might be 1-2 days

Ok thank you :P

Wouldnt commit b370506 fix this issue?

Edit: Fixed my commit reference

Do you mean b370506?

:)

Yeah haha

Any idea when a new beta build will be released?

Buddy, you seem a bit too hasty. How about a Potion of Slowness? :o)

@EzerArch Was only asking because i wanted to use some of the new features with my addon and wanted other people to be able to use the api changes that my addon uses....

when a new beta build will be released

  • I usually make a fresh build on Jenkins when I think a small milestone has been reached, or I think people might be interested to see something, or I have fixed a game-breaking bug in a prior build.

  • If you need a fresh build on Jenkins, any time, just ask me.

  • More official releases than that - forum and website - are up to micdoodle8.

@radfast No problem, didnt mean to sound rude. Just was looking forward to the features that have been added :D. IE this one

@micdoodle8 Please could we have a update to date beta build for 1.8.9 :P as i really want the new features :D
CC @radfast

@MJRLegends can it wait a few days? The Painter block is still WIP, it has no GUI right now.
(and for your own testing I guess you are building the mod yourself anyhow?)

@radfast Yeah i can wait a few days no problem, and yeah but i want it so i can release my addon update and use the GC new stuff and new/fixed api stuff

Was this page helpful?
0 / 5 - 0 ratings