Galacticraft: [GC & Smart Moving] Can't fit in 1x1 spaces after a while of playing

[Fernando540]

I can crawl into 1x1 spaces for a little while, but then something happens and I cannot do it anymore. When I exit and reconnect I can do it again for a moment but the the error still coming after a while.

Mods I have installed:
-GC (Core, Planets & MicdoodleCore) 1.7-3.0.12.454
-PowerSuits 0.11.0.300 & Numina 0.4.0.131
-OF HD UD1
-Player API 1.7.10-1.4
-Render Player API 1.7.10-1.4
-SmartMoving 15.6 & SmartRender 2.1

[EzerArch]

Geez, I had plans to open an issue listing the remaining incompatibilities between GC and SM. This is one of them.

This bug breaks one of the SM's features: crawling through 1-block tall passages. _(NEW: See Glitch 3 below. The problem is not in the crawling movement. The player's head collision detection is 1 block off!)_

But I made some tests already, version by version, from 411 to 440, the bug appears in 439.

Reproducing:
_Glitch 1 - 1-block tall hole:_

1. Build a wall and open a 1-block tall passage.
2. Shift+Control to crawl, and try to crawl through the hole.
3. You can't. The game thinks the player still has a 2-block tall hitbox while crawling. It was expected to be able to crawl through the hole but you'll stop at the opening.

_Glitch 2 - 2-block tall room:_

1. Build a 2-block tall room.
2. Walk beneath the ceiling.
3. Press Shift+Control to crawl.
4. Release Shift+Control.
5. You are stuck in the crawling position even if there is enough room to stand up. It was expected to be in the standing position as soon as I release the Shift+Control. The game thinks the player's head is already touching the ceiling. You have then to break the ceiling or to crawl away.

_Glitch 3 - Flying and space station (THE AHA MOMENT):_
This one gives away the bug!

1. Switch to creative.
2. Walk beneath a solid floor/blocks.
3. Fly up to hit the ceiling.
4. You'll notice the player stops 1 block away from the solid block.

In space stations, in survival:

1. Hold down Shift+Control to crawl
2. Press Spacebar to go up.
3. Player stops 1 block away from the ceiling.

_Extra - Player doesn't drown while swimming (not diving)_
If the player's head is 0.1~0.99 block underwater, the game will think the player is able to breath and he will never drown.

[dj3520]

What does F3 + B look like when crawling?

[Fernando540]

With GC installed:

Without GC:

[EzerArch]

What does F3 + B look like when crawling?

I don't trust the hitbox highlighter much, but it would be cool to have a comparison between SM + GC 438 and SM + GC 454 for a definitive test.

(Thanks @Fernando540 :+1: )

[dj3520]

Is the Jenkins back up? I haven't checked today.

[EzerArch]

Is the Jenkins back up?

Nope. But I have the files: http://ezerarch.com/downloads

[TheTerrorByte]

Not a galacticraft issue

[dj3520]

@Creeperman8362 um yes I think it is

But I had made some tests already, version by version, from 411 to 440, the bug appears in 439.

[radfast]

Thank you @EzerArch for this thorough testing.

I will look at this, but can't do much at the moment while the Jenkins is down. I don't have any magic way of accessing the Jenkins that you guys don't, it's in the cloud for me too. :) The server guys are working on it.

[dj3520]

@EzerArch Do you need access to some older builds for testing? My backup system recently got a fix as to not keep old files inside of new backups, but I forgot they were all dumped somewhere else for long term storage. TL;DR is

And yes, only those versions listed, but with a matching MicDoodleCore as well.

[radfast]

I need the changelog from the Jenkins to see what commits belong with version 439. If anyone has a saved copy of the changelog text ...

(Note to self: make local copies of that kind of stuff, in case the Jenkins goes offline again...)

[dj3520]

I need the changelog from the Jenkins

Figured it would of been that. Darn it.

[TheTerrorByte]

http://ci.micdoodle8.com/job/Galacticraft-1.7/changes

changelog

[dj3520]

@Creeperman8362 No offence but did you even check that link before posting? Specifically for #2151

[Zemor]

Any news on this issue?

[dj3520]

GC460 no SM

Witchery has lycanthropy, and when in dog form walking through 1 high spaces should be a thing, but it's not so.

_I should make a new skin_

[Zethalion]

I can confirm this is still an issue. Using:

• GalacticraftCore-1.7-3.0.12.463
• MicdoodleCore-1.7-3.0.12.463
• SmartMoving-1.7.10-15.6
• PlayerAPI-1.7.10-1.4
• SmartRender-1.7.10-2.1

Took me 2 whole days to find this weird behavior is due this incompatibility.

I only can ask help me out. I'd like to have GC inlcuded on my server. SM is just more important,

[dj3520]

Seeing as how this happens without SmartMoving at all (my testing with Witchery above) then I'm led to believe it's a Galacticraft problem.

[EzerArch]

It is a Galacticraft problem:

But I made some tests already, version by version, from 411 to 440, the bug appears in 439.

https://github.com/micdoodle8/Galacticraft/issues/2158#issuecomment-199101413

[dj3520]

@EzerArch does this mean that it isn't present in 438?

[EzerArch]

@dj3520 Nope. As I said, I tested version by version, from 411 to 440.

[dj3520]

@EzerArch ah, then perhaps it's 2eb466e7d7b7379f91190fef2adb45efd78527b1 Line 37 looks suspicious, but I have no experience in Java.

[masterfulmadman]

I understand that there is no easy solution, but is there a solution? I also encountered this issue and would like to know if it is possible to keep both galacticraft and smartmoving without losing functionality in a future update.

[EzerArch]

but is there a solution?

Besides someone who knows Java picking up the offending build (i.e. 439) and fixing the bug, no. And micdoodle can't afford fixing non-critical bugs as he's focused on porting the mod in his limited spare time.

@EzerArch ah, then perhaps it's 2eb466e Line 37 looks suspicious, but I have no experience in Java.

You mean this line? Yeah, pretty likely, but I have little modding literacy to be certain. If I had the environment on the go, I could try reverting the lines 34-39 just for a _deus ex machina_ moment.

[dj3520]

There's a lot of modification of the binding box from 31-39 (didn't know you could reference line numbers themselves via link, neat) but I have no idea what they accomplish or attempt. If I had an environment to compile java at all, I'd fork and revert that commit just to see. But even if that solves the issue, it still doesn't solve #1883 / #2170 which as it turns out, I'm still seeing happen in survival.

[dj3520]

Skimming through #1833 made me realize 375616a also changes binding boxes and is included in versions +441

Something interesting to note as well is the amount of downward force when sneaking is greater with hard mode on

If I had to guess it might have to do something with this:

The player appears to have a quick involuntary "bounce" down and up when starting downward movement in freefall, this is the result of the 'Sneak' mechanics in the vanilla game and is something we are working very hard to eliminate

This tells me that something was done to the sneak at the start of it. What confuses me completely though is that in my testing, restarting the server means every block I tested was fixed, even if I removed and replaced it. I'm guessing something at the start makes everything in the world correct when first loaded, but then as things change this check or whatever isn't triggered again, meaning ceilings that are newly added since the server started have issues, but ones that are old are fine, even if the blocks are changed.

[BionicFelps]

This is currently driving me crazy in a pack I'm playing (and made), bat form loses the ability to hit mobs, and has shorter reach for the payoff of being 1x1 block, is there any temporary workaround besides disabling galacticraft or ignoring it? lol

[dj3520]

At the moment, sadly, no.

[Kerai]

It took me about 10 seconds to find the source of this problem...

PlayerClient.java#L176,L182

Seems Galacticraft is changing height of a player and moving the top of boundingbox accordingly. Obviously this will cause compatibility problems with any mod that also changes player height.

Sure, commenting out these lines obviously fixes the issue. I don't think they are that necessary anyway as they are just for looks.

Here's a compiled jar with these lines commented out - for those who don't want to build the whole project just for this small change.

[EzerArch]

Here's a compiled jar with these lines commented out - for those who don't want to build the whole project just for this small change.

Thank you @Kerai. Is this change against GC464?

Seriously this will not break anything else in GC? I'll contact micdoodle to see it; this is pretty much requested. You can also PR the change if you wish.

[Kerai]

I changed against latest code from 1.7 branch. So, newer than 464. This shouldn't break anything else in GC.

As for PR - yeah, I might make a proper change later. (check if mods like SmartMoving are installed, and if not, only then change player height) Right now it's just a quick and dirty fix.

[dj3520]

Ah, the player is made slightly taller if wearing an oxygen mask.

[EzerArch]

Ref. https://github.com/micdoodle8/Galacticraft/issues/2158#issuecomment-199101413:
Glitch 1 - 1-block tall hole: fixed.
Glitch 2 - 2-block tall room: fixed
Glitch 3 - Flying and space station: fixed
Extra - Player doesn't drown while swimming: fixed
Thank you @Kerai. :)

[EzerArch]

Update - Partial bonus fix: Cryogenic Chamber is back working, but as ordinary bed. You can use it if it's night time on the Overworld but the cool-down time event can't be called. As Smart Moving user, I no longer get stuck in the cryo-chamber.

(I don't like double-posting, but this is really a new/significant info.)

[dj3520]

Gotta love it when a pull request fixes things. The players care!

[micdoodle8]

Thanks for the fix @Kerai, don't have a 1.7.10 workspace at the moment so it's much appreciated. Please re-open if there are remaining issues.

[EzerArch]

@Kerai, just a question: did you create a 1.7.10 workspace with no problems? Did it compile normally?

I'm just wondering if some other people might have had problems with compiling for 1.7.10 (e.g. #2390).

[Brayan2005]

There is so much to read that i didn't understood. So my problem is glitch 1 so what schould i do? (Is galacticraft the problem?)

[Brayan2005]

Is there realy no other solution as removing Galacticraft?

[dj3520]

@Brayan2005 If you're using the newest versions of both mods and the issue exists, it would probably be best to make a new issue report. With that being said I'm pretty sure development has moved on to newer versions.