Gala: Invalid app definition in the notification center

[ghost]

If notification comes in telegram, it is defined as notification from IntelliJ IDEA.

Telegram version: 1.1.19. Downloaded from oficial site. Extracted to /opt/Telegram/.
IntelliJ IDEA version: 2017.2.2. Downloaded from JetBrains ToolBox App.
elementaryOS version: 0.4.1 stable. All updates are installed.

[Philip-Scott]

@BrusAndr Can you post the contents of the InteliJ IDEA's .desktop file?

It should be located under /usr/share/applications or under '/home/your-user/.local/share/applications` :)

Thanks

[ghost]

@Philip-Scott

[Desktop Entry]
Version=1.0
Type=Application
Name=IntelliJ IDEA Ultimate
Icon=/opt/JetBrains/apps/IDEA-U/ch-0/172.3757.52/.icon.svg
Exec="/opt/JetBrains/apps/IDEA-U/ch-0/172.3757.52/bin/idea.sh" %f
Comment=Capable and ergonomic Java IDE
Categories=Development;IDE;
Terminal=false
StartupWMClass=jetbrains-idea

[Philip-Scott]

Can you remove the " from the Exec line, reboot and test if you can still reproduce it? :)

[ghost]

OMG
It really works :)
Thanks

[png2378]

@Philip-Scott so, whose is that bug? Gala or 3rd party app? 😊

[Philip-Scott]

@png2378 It's really a 3rd party bug since they're making an invalid .desktop file, but i think we should be catching that error and just ignoring that app instead of gala saying that it's this invalid app's notification

[peteruithoven]

You could use the AppEditor application to locate and edit the desktop file.

Don't forget to open an issue in the issue queue of the third party app.

That Exec seems to be valid:

Arguments may be quoted in whole. If an argument contains a reserved character the argument must be quoted. The rules for quoting of arguments is also applicable to the executable name or path of the executable program as provided.

From: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s07.html (edited)

[Philosoft]

For history. @Philip-Scott

Arguments may be quoted in whole. If an argument contains a reserved character the argument must be quoted. The rules for quoting of arguments is also applicable to the executable name or path of the executable program as provided.

quoted from spec

seems legit to me

[jlnr]

I was curious and wanted to see how the notification system works, so: What was happening in the wingpanel indicator is that Utils.vala looked at app_info.get_executable (), which returned a string in quotes for IntelliJ (the first part of Exec=). Since the code didn't consider this an absolute path (it started with ", not /) it tried to look up this binary (the full quoted string) in $PATH, finding null. As it couldn't find Telegram in $PATH either, the notification was attributed to IntelliJ (matching executables: null == null).

The linked PR should fix it, anyway :tada:

[cmonagle]

It looks like the PR to resolve this issue was closed... will this be resolved in Juno?

[donadigo]

This should probably be closed because the PR to fix this was merged to master: https://github.com/elementary/wingpanel-indicator-notifications/pull/44, (another words, yes, resolved in Juno).