Fzf: Garbled (doubled) text when using CTRL+r in Bash

[orschiro]

Dear all,

Can someone please explain to me why I use garbled (doubled) text when using Ctrl+r in Bash, select an entry and then press Return?

Thankfully,

-Robert

[junegunn]

Please fill in issue template when you create an issue. Did you check everything on the template?

[orschiro]

Dear @junegunn,

Please see below.

<!-- Check all that apply [x] -->
- Category
    - [x] fzf binary
    - [ ] fzf-tmux script
    - [x] Key bindings
    - [ ] Completion
    - [ ] Vim
    - [ ] Neovim
    - [ ] Etc.
- OS
    - [x] Linux
    - [ ] Mac OS X
    - [ ] Windows
    - [ ] Etc.
- Shell
    - [x] bash
    - [ ] zsh
    - [ ] fish

[junegunn]

Which linux distro are you running? What is the version of bash? I couldn't reproduce the problem with LXTerminal or gnome-terminal on Ubuntu 14.04.

[orschiro]

Dear @junegunn,

I am running Ubuntu Unity 16.04, Bash 4.3.46(1) and GNOME Terminal 3.18.3.

-Robert

[leonklingele]

So is this really a bug inside bash and needs to be reported to the bash developers?
I have only encountered this issue when using fzf.

[orschiro]

Sorry, I stopped using fzf and cannot longer comment.

[leonklingele]

FYI: I've reported the bug on the bash issue tracker:
https://lists.gnu.org/archive/html/bug-bash/2017-08/msg00017.html

[rdlugosz]

Per the conversation on the Bash issue tracker (linked above), it seems like the consensus is that fzf is not outputting the text quite right. One solution is to terminate the line with a clear screen character, but this has the side effect of clearing the screen. See the thread for more detail. Thoughts?

[junegunn]

I still think that bash is not working correctly here as we trigger redraw-current-line at the end of the binding. No? But it looks like we can trivially workaround the issue by triggering it before, instead of after, history-expand-line. So let me push the fix.

[leonklingele]

This indeed fixed the issue. Thanks @junegunn 🐳

[jjlee]

Sorry to pollute the comment history, but I just wanted to say thanks @junegunn for fixing this bug (and for fzf), this will help me about every 5 minutes every day, I can't believe I didn't notice this fix for a year! :heart: