Fuel: Kotlin naming conventions violation in RxFuel

Created on 20 Sep 2018  路  6Comments  路  Source: kittinunf/fuel

Refactoring

Description

Add to com.github.kittinunf.fuel.rx.RxFuel methods toRxRespone(), toRxResponseString() etc. Deprecate old methods.

Why this is necessary?

Current naming violate Kotlin style: link

chore

Most helpful comment

Maybe we can link to official code style here. Spoiler alert, I wasn't very much following it.

All 6 comments

@milk-machine are you going to submit a pr?

I would also like to have a reference what is "Kotlin style naming", so that we can link to it in CONTRIBUTING and/or a style guide.

Maybe we can link to official code style here. Spoiler alert, I wasn't very much following it.

There is something like https://github.com/shyiko/ktlint. Oh course, it would increase the build times. :|

I actually think klint is smart to add! It should be fast (only a few seconds) as most linters usually run inline with your code anyway.

Added: #442

Was this page helpful?
0 / 5 - 0 ratings

Related issues

iNoles picture iNoles  路  5Comments

iNoles picture iNoles  路  5Comments

fyi2 picture fyi2  路  3Comments

IvanKulikov picture IvanKulikov  路  5Comments

lionlollipop picture lionlollipop  路  3Comments