In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:
How familiar are you with the codebase?:
3
[BUG | ISSUE] Expected Behaviour:
new FTL binary downloads via curl
[BUG | ISSUE] Actual Behaviour:
Binary doesn't download and gets a 404.
[BUG | ISSUE] Steps to reproduce:
curl -sSL https://install.pi-hole.net | bash
Log file output [if available]
[i] Checking for existing FTL binary...
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL not found
output
n/a
Device specifics
Pi3 armv7+
Hardware Type: rPi, VPS, etc
OS: Raspbian (Linux version 4.14.18-v7+)
_This template was created based on the work of udemy-dl._
Thanks, we are aware and working on the fix for that now.
The release is broken for pihole -up or anything that invokes basic-install.sh because none of the binary Assets have been uploaded to the release here on GitHub.
Trying to upgrade yields a curl 404 error trying to download https://github.com/pi-hole/FTL/releases/download/v3.0/pihole-FTL-linux-x86_64 (or whichever binary is suitable for the user's platform).
Try again, it should be fixed.
can confirm its work as expected now
Thanks, it's working perfectly now!
I installed pi hole yesterday (Aug. 4 2018) and today (Aug. 5 2018) I saw that an update is available. I ran the 'sudo pihole -up' command and have run into the exact same error as described in this issue.
We had a small issue that should be resolved now.
We just released a few moments ago, please try again.
Thanks for the super fast response (1 minute.. that must be a new record :) ). What do I need to do to get this working again? I simply re-tried 'sudo pihole -up' but the issue has not disappeared for me. Thanks in advance.
@sagarbehere what is the output of the update command? Run pihole -d for a debug token.
@Mcat12 Hmm... the matter seems to have resolved itself after I uninstalled pi hole and did a clean reinstall. No more issues.
Tried a few moments ago:
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL not found
[โ] Your debug token is: ri85h5pi13.
Updated FTL manually with wget and sudo install -T -m 0755 pihole-FTL-arm-linux-{myarch} /usr/bin/pihole-FTL. seems to be working
Same here, tried to update to 4.0 in Debian Stretch:
[โ] Checking for lighttpd
[โ] Checking for php7.0-common
[โ] Checking for php7.0-cgi
[โ] Checking for php7.0-sqlite3
Can't call method "set" on an undefined value at /usr/share/perl5/Debconf/FrontEnd.pm line 126,
Use of uninitialized value $ret in scalar chomp at /usr/share/perl5/Debconf/Client/ConfModule.pm line 132,
Use of uninitialized value $ret in split at /usr/share/perl5/Debconf/Client/ConfModule.pm line 133,
Use of uninitialized value $ret[0] in string eq at /usr/share/perl5/Debconf/Client/ConfModule.pm line 134,
Use of uninitialized value $ret[0] in string eq at /usr/bin/debconf-apt-progress line 173,
Unable to complete update, please contact Pi-hole Support
After these issues I tried again, which is the current issue:
(~)($) pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] FTL: update available
[i] FTL out of date
[i] FTL Checks...
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL not found
Do you have a file called /etc/pihole/ftlbranch ? If so, please remove this file.
(/etc/pihole)($) ls -la | grep -i ftl
-rw-r--r-- 1 pihole pihole 178233344 Aug 6 10:05 pihole-FTL.db
No there is no such file.
Apparently I fixed it, I reran and apt-get update/upgrade...
($) sudo apt-get upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
1 not fully installed or removed.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Setting up resolvconf (1.79) ...
Created symlink /etc/systemd/system/sysinit.target.wants/resolvconf.service โ /lib/systemd/system/resolvconf.service.
Processing triggers for resolvconf (1.79) ...
W: APT had planned for dpkg to do more than it reported back (0 vs 4).
Affected packages: resolvconf:amd64
After this I ran a repair:
pihole -r
Now all is OK:
(root) (Mon Aug 06 10:31:32)
($) pihole -v
Pi-hole version is v4.0 (Latest: v4.0)
AdminLTE version is v4.0 (Latest: v4.0)
FTL version is v4.0 (Latest: v4.0)
(root) (Mon Aug 06 10:31:36)
($) pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] Web Interface: up to date
[i] FTL: up to date
[โ] Everything is up to date!
@FoUStep: worked like a charm.
Result of last step at the very end slightly different:
root@DietPi:~# pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] Web Interface: update available
[i] FTL: up to date
[i] Pi-hole Web Admin files out of date, updating local repo.
[โ] Check for existing repository in /var/www/html/admin
[โ] Update repo in /var/www/html/admin
[i] If you had made any changes in '/var/www/html/admin/', they have been stashed using 'git stash'
Everything is up-to-date now.
same issue 404 error, i don't have ftl branch file
48voj4ya4o
same issue as well, 404 error.
d5oiokv7fj
thanks
same at me
jwlg5k27rv
thanks
domino
Share the output of uname -m and the output of pihole -up
root@PiHole:/home/jxer# uname -m
x86_64
root@PiHole:/home/jxer# pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] FTL: update available
[i] FTL out of date
[i] FTL Checks...
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL not found
root@PiHole:/home/jxer#
@jxer What is the output of this command? sudo bash -x /opt/pihole/update.sh
sudo bash -x /opt/pihole/update.sh
+ readonly ADMIN_INTERFACE_GIT_URL=https://github.com/pi-hole/AdminLTE.git
+ ADMIN_INTERFACE_GIT_URL=https://github.com/pi-hole/AdminLTE.git
+ readonly ADMIN_INTERFACE_DIR=/var/www/html/admin
+ ADMIN_INTERFACE_DIR=/var/www/html/admin
+ readonly PI_HOLE_GIT_URL=https://github.com/pi-hole/pi-hole.git
+ PI_HOLE_GIT_URL=https://github.com/pi-hole/pi-hole.git
+ readonly PI_HOLE_FILES_DIR=/etc/.pihole
+ PI_HOLE_FILES_DIR=/etc/.pihole
+ PH_TEST=true
+ source '/etc/.pihole/automated install/basic-install.sh'
++ set -e
++ installLogLoc=/etc/pihole/install.log
++ setupVars=/etc/pihole/setupVars.conf
++ lighttpdConfig=/etc/lighttpd/lighttpd.conf
++ coltable=/opt/pihole/COL_TABLE
++ webInterfaceGitUrl=https://github.com/pi-hole/AdminLTE.git
++ webInterfaceDir=/var/www/html/admin
++ piholeGitUrl=https://github.com/pi-hole/pi-hole.git
++ PI_HOLE_LOCAL_REPO=/etc/.pihole
++ PI_HOLE_FILES=(chronometer list piholeDebug piholeLogFlush setupLCD update version gravity uninstall webpage)
++ PI_HOLE_INSTALL_DIR=/opt/pihole
++ PI_HOLE_CONFIG_DIR=/etc/pihole
++ useUpdateVars=false
++ adlistFile=/etc/pihole/adlists.list
++ regexFile=/etc/pihole/regex.list
++ IPV4_ADDRESS=
++ IPV6_ADDRESS=
++ QUERY_LOGGING=true
++ INSTALL_WEB_INTERFACE=true
++ '[' -z root ']'
+++ stty size
++ screen_size='59 168'
+++ awk '{print $1}'
+++ echo '59 168'
++ rows=59
+++ awk '{print $2}'
+++ echo '59 168'
++ columns=168
++ r=29
++ c=84
++ r=29
++ c=84
++ skipSpaceCheck=false
++ reconfigure=false
++ runUnattended=false
++ INSTALL_WEB_SERVER=true
++ [[ -f /opt/pihole/COL_TABLE ]]
++ source /opt/pihole/COL_TABLE
+++ [[ -t 1 ]]
++++ tput colors
+++ [[ 8 -ge 8 ]]
+++ COL_BOLD=''
+++ COL_ULINE=''
+++ COL_NC=''
+++ COL_GRAY=''
+++ COL_RED=''
+++ COL_GREEN=''
+++ COL_YELLOW=''
+++ COL_BLUE=''
+++ COL_PURPLE=''
+++ COL_CYAN=''
+++ COL_WHITE=''
+++ COL_BLACK=''
+++ COL_LIGHT_BLUE=''
+++ COL_LIGHT_GREEN=''
+++ COL_LIGHT_CYAN=''
+++ COL_LIGHT_RED=''
+++ COL_URG_RED=''
+++ COL_LIGHT_PURPLE=''
+++ COL_BROWN=''
+++ COL_LIGHT_GRAY=''
+++ COL_DARK_GRAY=''
+++ TICK='[โ]'
+++ CROSS='[โ]'
+++ INFO='[i]'
+++ QST='[?]'
+++ DONE=' done!'
+++ OVER='\r'
++ counter=0
++ [[ true != true ]]
+ source /opt/pihole/COL_TABLE
++ [[ -t 1 ]]
+++ tput colors
++ [[ 8 -ge 8 ]]
++ COL_BOLD=''
++ COL_ULINE=''
++ COL_NC=''
++ COL_GRAY=''
++ COL_RED=''
++ COL_GREEN=''
++ COL_YELLOW=''
++ COL_BLUE=''
++ COL_PURPLE=''
++ COL_CYAN=''
++ COL_WHITE=''
++ COL_BLACK=''
++ COL_LIGHT_BLUE=''
++ COL_LIGHT_GREEN=''
++ COL_LIGHT_CYAN=''
++ COL_LIGHT_RED=''
++ COL_URG_RED=''
++ COL_LIGHT_PURPLE=''
++ COL_BROWN=''
++ COL_LIGHT_GRAY=''
++ COL_DARK_GRAY=''
++ TICK='[โ]'
++ CROSS='[โ]'
++ INFO='[i]'
++ QST='[?]'
++ DONE=' done!'
++ OVER='\r'
+ main
+ local pihole_version_current
+ local web_version_current
+ local 'basicError=\n Unable to complete update, please contact Pi-hole Support'
+ source /etc/pihole/setupVars.conf
++ WEBPASSWORD=dc817f46dece483137dc592f7a8e03458abaa25ad51aee94abd74812d8d6b52f
++ PIHOLE_INTERFACE=eth0
++ IPV4_ADDRESS=10.21.0.20/24
++ IPV6_ADDRESS=
++ PIHOLE_DNS_1=8.8.8.8
++ PIHOLE_DNS_2=8.8.4.4
++ QUERY_LOGGING=true
++ INSTALL_WEB=true
++ LIGHTTPD_ENABLED=1
+ is_repo /etc/.pihole
+ local directory=/etc/.pihole
+ local curdir
+ local rc
+ curdir=/home/jxer
+ [[ -d /etc/.pihole ]]
+ cd /etc/.pihole
+ git status --short
+ cd /home/jxer
+ return 0
+ echo -e ' [i] Checking for updates...'
[i] Checking for updates...
+ GitCheckUpdateAvail /etc/.pihole
+ local directory=/etc/.pihole
+ curdir=/home/jxer
+ cd /etc/.pihole
+ git fetch --quiet origin
++ git rev-parse '@{0}'
+ LOCAL=ddbdb51d209fa9eea2451a1bebfaeaef23a9b77b
++ git rev-parse '@{upstream}'
+ REMOTE=ddbdb51d209fa9eea2451a1bebfaeaef23a9b77b
+ [[ 40 == 0 ]]
+ [[ 40 == 0 ]]
+ cd /home/jxer
+ [[ ddbdb51d209fa9eea2451a1bebfaeaef23a9b77b != \d\d\b\d\b\5\1\d\2\0\9\f\a\9\e\e\a\2\4\5\1\a\1\b\e\b\f\a\e\a\e\f\2\3\a\9\b\7\7\b ]]
+ return 1
+ core_update=false
+ echo -e ' [i] Pi-hole Core:\tup to date'
[i] Pi-hole Core: up to date
+ FTLcheckUpdate
+ local FTLversion
++ /usr/bin/pihole-FTL tag
+ FTLversion=v3.0
+ local FTLlatesttag
++ tr -d '\r\n'
++ awk -F / '{print $NF}'
++ grep Location
++ curl -sI https://github.com/pi-hole/FTL/releases/latest
+ FTLlatesttag=v4.0
+ [[ v3.0 != \v\4\.\0 ]]
+ return 0
+ FTL_update=true
+ echo -e ' [i] FTL:\t\tupdate available'
[i] FTL: update available
+ true
+ false
+ echo ''
+ echo -e ' [i] FTL out of date'
[i] FTL out of date
+ FTLdetect
+ echo ''
+ echo -e ' [i] FTL Checks...'
[i] FTL Checks...
+ FTLcheckUpdate
+ local FTLversion
++ /usr/bin/pihole-FTL tag
+ FTLversion=v3.0
+ local FTLlatesttag
++ tr -d '\r\n'
++ awk -F / '{print $NF}'
++ grep Location
++ curl -sI https://github.com/pi-hole/FTL/releases/latest
+ FTLlatesttag=v4.0
+ [[ v3.0 != \v\4\.\0 ]]
+ return 0
+ FTLinstall ''
+ local binary=
+ local latesttag
+ local 'str=Downloading and Installing FTL'
+ echo -ne ' [i] Downloading and Installing FTL...'
[i] Downloading and Installing FTL...++ awk -F / '{print $NF}'
++ grep Location
++ curl -sI https://github.com/pi-hole/FTL/releases/latest
+ latesttag=$'v4.0\r'
== v* ]].0
++ mktemp -d
+ pushd /tmp/tmp.0A2IIwTIhB
+ install -T -m 0755 /etc/.pihole/advanced/Templates/pihole-FTL.service /etc/init.d/pihole-FTL
+ local ftlBranch
+ local url
+ [[ -f /etc/pihole/ftlbranch ]]
+ ftlBranch=master
+ [[ master == \m\a\s\t\e\r ]]
+ url=https://github.com/pi-hole/FTL/releases/download/v4.0
+ curl -sSL --fail https://github.com/pi-hole/FTL/releases/download/v4.0/ -o ''
curl: (22) The requested URL returned error: 404 Not Found
+ popd
+ echo -e '\r [โ] Downloading and Installing FTL'
[โ] Downloading and Installing FTL
+ echo -e ' Error: URL not found'
Error: URL not found
+ return 1
+ return 1
I'm seeing the same issue. My output to update.sh ends the same as @jxer
$ uname -m
armv7l
[โ] Your debug token is: 6khjgiokrg
Try changing DNS you must remove 127.0.0.1 from
sudo nano /etc/resolv.conf
nameserver 8.8.8.8
nameserver 8.8.4.4
Run pihole -up
hope that helps
Same error and architecture as @slootsky
Changing DNS to 8.8.8.8 does nothing.
Not familiar with the codebase, but does it relate at all to #344 ?
Could you guys upload the following files to pastebin and provide the links please?
/etc/.pihole/automated\ install/basic-install.sh/opt/pihole/update.shThanks!
Also the output of: cd /etc/.pihole/ && git status
I think I can see what the issue is. It appears that each of you have the pre 4.0 version of update.sh in your /opt/pihole directories (based on the output of the bash -x commands ran above), and that something went wrong with the install script during your initial run of pihole -up.
The way the updater works is to first update the local repositories, and then run the installer. This is the point where something went wrong. Looking at @FoUStep's comments above, this was due to an issue when checking apt for updates/upgrades. At this point, the installer crashed out and did not distribute the latest version of the scripts to /opt/pihole. Any subsequent runs of pihole -up are reporting that the local repo is up to date, (but it's not detecting that the files in /opt/pihole are out of date, so admitedly we have a bug here), and therefore there is no reason for it to want to run the installer.
The old version of update.sh included calls to check for FTL updates directly, but the logic for this has now been moved into the install script.
As per @FoUStep's comments above, please try running:
sudo apt update
sudo apt upgrade
pihole -r
I believe this should fix the issues you are seeing. If the installer spits out any errors after running pihole -r, then please post them here (or create a new issue on the core repo) and we can further attempt to diagnose the issue.
the curl is pulling the wrong directory from what i can see, but what do i know
jxer@PiHole:~$ su
Password:
root@PiHole:/home/jxer# sudo apt update
Get:1 http://security.debian.org stretch/updates InRelease [94.3 kB]
Ign:2 http://ftp.us.debian.org/debian stretch InRelease
Get:3 http://ftp.us.debian.org/debian stretch-updates InRelease [91.0 kB]
Hit:4 http://ftp.us.debian.org/debian stretch Release
Fetched 185 kB in 0s (351 kB/s)
Reading package lists... Done
Building dependency tree
Reading state information... Done
1 package can be upgraded. Run 'apt list --upgradable' to see it.
root@PiHole:/home/jxer# sudo apt upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following NEW packages will be installed:
linux-image-4.9.0-7-amd64
The following packages will be upgraded:
linux-image-amd64
1 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 39.1 MB of archives.
After this operation, 193 MB of additional disk space will be used.
Do you want to continue? [Y/n] y
Abort.
root@PiHole:/home/jxer# sudo apt upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following NEW packages will be installed:
linux-image-4.9.0-7-amd64
The following packages will be upgraded:
linux-image-amd64
1 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 39.1 MB of archives.
After this operation, 193 MB of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://security.debian.org stretch/updates/main amd64 linux-image-4.9.0-7-amd64 amd64 4.9.110-3+deb9u1 [39.1 MB]
Get:2 http://ftp.us.debian.org/debian stretch/main amd64 linux-image-amd64 amd64 4.9+80+deb9u5 [7,052 B]
Fetched 39.1 MB in 3s (12.3 MB/s)
Reading changelogs... Done
Selecting previously unselected package linux-image-4.9.0-7-amd64.
(Reading database ... 44271 files and directories currently installed.)
Preparing to unpack .../linux-image-4.9.0-7-amd64_4.9.110-3+deb9u1_amd64.deb ...
Unpacking linux-image-4.9.0-7-amd64 (4.9.110-3+deb9u1) ...
Preparing to unpack .../linux-image-amd64_4.9+80+deb9u5_amd64.deb ...
Unpacking linux-image-amd64 (4.9+80+deb9u5) over (4.9+80+deb9u4) ...
Setting up linux-image-4.9.0-7-amd64 (4.9.110-3+deb9u1) ...
I: /vmlinuz.old is now a symlink to boot/vmlinuz-4.9.0-6-amd64
I: /initrd.img.old is now a symlink to boot/initrd.img-4.9.0-6-amd64
I: /vmlinuz is now a symlink to boot/vmlinuz-4.9.0-7-amd64
I: /initrd.img is now a symlink to boot/initrd.img-4.9.0-7-amd64
/etc/kernel/postinst.d/initramfs-tools:
update-initramfs: Generating /boot/initrd.img-4.9.0-7-amd64
/etc/kernel/postinst.d/zz-update-grub:
Generating grub configuration file ...
Found linux image: /boot/vmlinuz-4.9.0-7-amd64
Found initrd image: /boot/initrd.img-4.9.0-7-amd64
Found linux image: /boot/vmlinuz-4.9.0-6-amd64
Found initrd image: /boot/initrd.img-4.9.0-6-amd64
Found linux image: /boot/vmlinuz-4.9.0-5-amd64
Found initrd image: /boot/initrd.img-4.9.0-5-amd64
done
Setting up linux-image-amd64 (4.9+80+deb9u5) ...
root@PiHole:/home/jxer# pihole -r
[โ] Root user check
.;;,.
.ccccc:,.
:cccclll:. ..,,
:ccccclll. ;ooodc
'ccll:;ll .oooodc
.;cll.;;looo:.
.. ','.
.',,,,,,'.
.',,,,,,,,,,.
.',,,,,,,,,,,,....
....''',,,,,,,'.......
......... .... .........
.......... ..........
.......... ..........
......... .... .........
........,,,,,,,'......
....',,,,,,,,,,,,.
.',,,,,,,,,'.
.',,,,,,'.
..'''.
[i] Existing PHP installation detected : PHP version 7.0.30-0+deb9u1
[i] Repair option selected
[โ] Disk space check
[โ] Update local cache of available packages
[โ] Checking apt-get for upgraded packages... up to date!
[i] Installer Dependency checks...
[โ] Checking for apt-utils
[โ] Checking for dialog
[โ] Checking for debconf
[โ] Checking for dhcpcd5
[โ] Checking for git
[โ] Checking for iproute2
[โ] Checking for whiptail
[i] Performing reconfiguration, skipping download of local repos
[โ] Resetting repository within /etc/.pihole...
[โ] Resetting repository within /var/www/html/admin...
[i] Main Dependency checks...
[โ] Checking for bc
[โ] Checking for cron
[โ] Checking for curl
[โ] Checking for dnsutils
[โ] Checking for iputils-ping
[โ] Checking for lsof
[โ] Checking for netcat
[โ] Checking for psmisc
[โ] Checking for sudo
[โ] Checking for unzip
[โ] Checking for wget
[โ] Checking for idn2
[โ] Checking for sqlite3
[โ] Checking for libcap2-bin
[โ] Checking for dns-root-data
[โ] Checking for resolvconf
[โ] Checking for lighttpd
[โ] Checking for php7.0-common
[โ] Checking for php7.0-cgi
[โ] Checking for php7.0-sqlite3
[i] Enabling lighttpd service to start on reboot...root@PiHole:/home/jxer# pihole -v
Pi-hole version is v4.0 (Latest: v4.0)
AdminLTE version is v4.0 (Latest: v4.0)
FTL version is v3.0 (Latest: v4.0)
root@PiHole:/home/jxer# pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] FTL: update available
[i] FTL out of date
[i] FTL Checks...
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL not found
root@PiHole:/home/jxer#
Ok, the installer still isn't completing, and your update.sh is still the wrong version. Hence the wrong curl command.
Installer is falling out here:
[i] Enabling lighttpd service to start on reboot...
So it's not even getting to the part where the scripts are copied.
Hmm. What is the output of sudo bash -x /etc/.pihole/automated\ install/basic-install.sh?
root@PiHole:/home/jxer# bash -x /etc/.pihole/automated\ install/basic-install.sh
+ set -e
+ installLogLoc=/etc/pihole/install.log
+ setupVars=/etc/pihole/setupVars.conf
+ lighttpdConfig=/etc/lighttpd/lighttpd.conf
+ coltable=/opt/pihole/COL_TABLE
+ webInterfaceGitUrl=https://github.com/pi-hole/AdminLTE.git
+ webInterfaceDir=/var/www/html/admin
+ piholeGitUrl=https://github.com/pi-hole/pi-hole.git
+ PI_HOLE_LOCAL_REPO=/etc/.pihole
+ PI_HOLE_FILES=(chronometer list piholeDebug piholeLogFlush setupLCD update version gravity uninstall webpage)
+ PI_HOLE_INSTALL_DIR=/opt/pihole
+ PI_HOLE_CONFIG_DIR=/etc/pihole
+ useUpdateVars=false
+ adlistFile=/etc/pihole/adlists.list
+ regexFile=/etc/pihole/regex.list
+ IPV4_ADDRESS=
+ IPV6_ADDRESS=
+ QUERY_LOGGING=true
+ INSTALL_WEB_INTERFACE=true
+ '[' -z root ']'
++ stty size
+ screen_size='59 168'
++ awk '{print $1}'
++ echo '59 168'
+ rows=59
++ awk '{print $2}'
++ echo '59 168'
+ columns=168
+ r=29
+ c=84
+ r=29
+ c=84
+ skipSpaceCheck=false
+ reconfigure=false
+ runUnattended=false
+ INSTALL_WEB_SERVER=true
+ [[ -f /opt/pihole/COL_TABLE ]]
+ source /opt/pihole/COL_TABLE
++ [[ -t 1 ]]
+++ tput colors
++ [[ 8 -ge 8 ]]
++ COL_BOLD=''
++ COL_ULINE=''
++ COL_NC=''
++ COL_GRAY=''
++ COL_RED=''
++ COL_GREEN=''
++ COL_YELLOW=''
++ COL_BLUE=''
++ COL_PURPLE=''
++ COL_CYAN=''
++ COL_WHITE=''
++ COL_BLACK=''
++ COL_LIGHT_BLUE=''
++ COL_LIGHT_GREEN=''
++ COL_LIGHT_CYAN=''
++ COL_LIGHT_RED=''
++ COL_URG_RED=''
++ COL_LIGHT_PURPLE=''
++ COL_BROWN=''
++ COL_LIGHT_GRAY=''
++ COL_DARK_GRAY=''
++ TICK='[โ]'
++ CROSS='[โ]'
++ INFO='[i]'
++ QST='[?]'
++ DONE=' done!'
++ OVER='\r'
+ counter=0
+ [[ '' != true ]]
+ main
+ local 'str=Root user check'
+ echo ''
+ [[ 0 -eq 0 ]]
+ echo -e ' [โ] Root user check'
[โ] Root user check
+ show_ascii_berry
+ echo -e '
.;;,.
.ccccc:,.
:cccclll:. ..,,
:ccccclll. ;ooodc
'\''ccll:;ll .oooodc
.;cll.;;looo:.
.. '\'','\''.
.'\'',,,,,,'\''.
.'\'',,,,,,,,,,.
.'\'',,,,,,,,,,,,....
....'\'''\'''\'',,,,,,,'\''.......
......... .... .........
.......... ..........
.......... ..........
......... .... .........
........,,,,,,,'\''......
....'\'',,,,,,,,,,,,.
.'\'',,,,,,,,,'\''.
.'\'',,,,,,'\''.
..'\'''\'''\''.
'
.;;,.
.ccccc:,.
:cccclll:. ..,,
:ccccclll. ;ooodc
'ccll:;ll .oooodc
.;cll.;;looo:.
.. ','.
.',,,,,,'.
.',,,,,,,,,,.
.',,,,,,,,,,,,....
....''',,,,,,,'.......
......... .... .........
.......... ..........
.......... ..........
......... .... .........
........,,,,,,,'......
....',,,,,,,,,,,,.
.',,,,,,,,,'.
.',,,,,,'.
..'''.
+ make_temporary_log
++ mktemp /tmp/pihole_temp.XXXXXX
+ TEMPLOG=/tmp/pihole_temp.hdursA
+ exec
+ rm /tmp/pihole_temp.hdursA
+ distro_check
+ command -v apt-get
+ PKG_MANAGER=apt-get
+ UPDATE_PKG_CACHE='apt-get update'
+ PKG_INSTALL=(${PKG_MANAGER} --yes --no-install-recommends install)
+ PKG_COUNT='apt-get -s -o Debug::NoLocking=true upgrade | grep -c ^Inst || true'
+ apt-get install --dry-run iproute2
+ iproute_pkg=iproute2
+ command -v php
++ grep -Po '(?<=PHP )[^ ]+'
++ head -n1
++ php -v
+ phpInsVersion=7.0.30-0+deb9u1
+ echo -e ' [i] Existing PHP installation detected : PHP version 7.0.30-0+deb9u1'
[i] Existing PHP installation detected : PHP version 7.0.30-0+deb9u1
++ cut -d. -f1
++ echo 7.0.30-0+deb9u1
+ phpInsMajor=7
++ cut -d. -f2
++ echo 7.0.30-0+deb9u1
+ phpInsMinor=0
++ bc
++ echo '7.0 < 7.0'
+ '[' 0 == 0 ']'
+ phpInsNewer=true
+ [[ true != true ]]
+ phpVer=php7.0
+ apt-get install --dry-run php7.0-sqlite3
+ phpSqlite=sqlite3
+ INSTALLER_DEPS=(apt-utils dialog debconf dhcpcd5 git ${iproute_pkg} whiptail)
+ PIHOLE_DEPS=(bc cron curl dnsutils iputils-ping lsof netcat psmisc sudo unzip wget idn2 sqlite3 libcap2-bin dns-root-data resolvconf)
+ PIHOLE_WEB_DEPS=(lighttpd ${phpVer}-common ${phpVer}-cgi ${phpVer}-${phpSqlite})
+ LIGHTTPD_USER=www-data
+ LIGHTTPD_GROUP=www-data
+ LIGHTTPD_CFG=lighttpd.conf.debian
+ [[ -f /etc/pihole/setupVars.conf ]]
+ [[ false == true ]]
+ update_dialogs
+ [[ false = true ]]
+ opt1a=Update
+ opt1b='This will retain existing settings.'
+ strAdd='You will be updated to the latest version.'
+ opt2a=Reconfigure
+ opt2b='This will reset your Pi-hole and allow you to enter new settings.'
++ whiptail --title 'Existing Install Detected!' --menu '\n\nWe have detected an existing install.\n\nPlease choose from the following options: \n(You will be updated to the latest version.)' 29 84 2 Update 'This will retain existing settings.' Reconfigure 'This will reset your Pi-hole and allow you to enter new settings.'
+ UpdateCmd=Update
+ case ${UpdateCmd} in
+ echo -e ' [i] Update option selected'
[i] Update option selected
+ useUpdateVars=true
+ [[ false == true ]]
+ verifyFreeDiskSpace
+ local 'str=Disk space check'
+ local required_free_kilobytes=51200
+ local existing_free_kilobytes
++ awk '{print $4}'
++ grep -m1 '\/$'
++ df -Pk
+ existing_free_kilobytes=1910252
+ [[ 1910252 =~ ^([0-9])+$ ]]
+ [[ 1910252 -lt 51200 ]]
+ echo -e ' [โ] Disk space check'
[โ] Disk space check
+ update_package_cache
+ local 'str=Update local cache of available packages'
+ echo ''
+ echo -ne ' [i] Update local cache of available packages...'
[i] Update local cache of available packages...+ eval 'apt-get update'
+ echo -e '\r [โ] Update local cache of available packages'
[โ] Update local cache of available packages
+ notify_package_updates_available
+ local 'str=Checking apt-get for upgraded packages'
+ echo -ne '\n [i] Checking apt-get for upgraded packages...'
[i] Checking apt-get for upgraded packages...++ eval 'apt-get -s -o Debug::NoLocking=true upgrade | grep -c ^Inst || true'
+++ grep -c '^Inst'
+++ apt-get -s -o Debug::NoLocking=true upgrade
+++ true
+ updatesToInstall=0
++ uname -r
+ [[ -d /lib/modules/4.9.0-6-amd64 ]]
+ [[ 0 -eq 0 ]]
+ echo -e '\r [โ] Checking apt-get for upgraded packages... up to date!'
[โ] Checking apt-get for upgraded packages... up to date!
+ echo ''
+ install_dependent_packages 'INSTALLER_DEPS[@]'
+ counter=1
+ [[ 1 == 1 ]]
+ echo -e ' [i] Installer Dependency checks...'
[i] Installer Dependency checks...
+ argArray1=("${!1}")
+ declare -a argArray1
+ declare -a installArray
+ command -v debconf-apt-progress
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for apt-utils...'
[i] Checking for apt-utils...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' apt-utils
+ echo -e '\r [โ] Checking for apt-utils'
[โ] Checking for apt-utils
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for dialog...'
[i] Checking for dialog...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' dialog
+ echo -e '\r [โ] Checking for dialog'
[โ] Checking for dialog
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for debconf...'
[i] Checking for debconf...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' debconf
+ echo -e '\r [โ] Checking for debconf'
[โ] Checking for debconf
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for dhcpcd5...'
[i] Checking for dhcpcd5...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' dhcpcd5
+ echo -e '\r [โ] Checking for dhcpcd5'
[โ] Checking for dhcpcd5
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for git...'
[i] Checking for git...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' git
+ echo -e '\r [โ] Checking for git'
[โ] Checking for git
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for iproute2...'
[i] Checking for iproute2...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' iproute2
+ echo -e '\r [โ] Checking for iproute2'
[โ] Checking for iproute2
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for whiptail...'
[i] Checking for whiptail...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' whiptail
+ echo -e '\r [โ] Checking for whiptail'
[โ] Checking for whiptail
+ [[ 0 -gt 0 ]]
+ echo ''
+ return 0
+ checkSelinux
+ command -v getenforce
+ [[ true == false ]]
+ source /etc/pihole/setupVars.conf
++ WEBPASSWORD=dc817f46dece483137dc592f7a8e03458abaa25ad51aee94abd74812d8d6b52f
++ PIHOLE_INTERFACE=eth0
++ IPV4_ADDRESS=10.21.0.20/24
++ IPV6_ADDRESS=
++ PIHOLE_DNS_1=8.8.8.8
++ PIHOLE_DNS_2=8.8.4.4
++ QUERY_LOGGING=true
++ INSTALL_WEB=true
++ LIGHTTPD_ENABLED=1
+ clone_or_update_repos
+ [[ false == true ]]
+ getGitFiles /etc/.pihole https://github.com/pi-hole/pi-hole.git
+ local directory=/etc/.pihole
+ local remoteRepo=https://github.com/pi-hole/pi-hole.git
+ local 'str=Check for existing repository in /etc/.pihole'
+ echo -ne ' [i] Check for existing repository in /etc/.pihole...'
[i] Check for existing repository in /etc/.pihole...+ is_repo /etc/.pihole
+ local directory=/etc/.pihole
+ local curdir
+ local rc
+ curdir=/home/jxer
+ [[ -d /etc/.pihole ]]
+ cd /etc/.pihole
+ git status --short
+ cd /home/jxer
+ return 0
+ echo -e '\r [โ] Check for existing repository in /etc/.pihole'
[โ] Check for existing repository in /etc/.pihole
+ update_repo /etc/.pihole
+ local directory=/etc/.pihole
+ local curdir
+ local 'str=Update repo in /etc/.pihole'
+ curdir=/home/jxer
+ cd /etc/.pihole
+ echo -ne ' [i] Update repo in /etc/.pihole...'
[i] Update repo in /etc/.pihole...+ git stash --all --quiet
+ git clean --quiet --force -d
+ git pull --quiet
+ echo -e '\r [โ] Update repo in /etc/.pihole'
[โ] Update repo in /etc/.pihole
+ cd /home/jxer
+ return 0
+ echo ''
+ return 0
+ [[ true == true ]]
+ getGitFiles /var/www/html/admin https://github.com/pi-hole/AdminLTE.git
+ local directory=/var/www/html/admin
+ local remoteRepo=https://github.com/pi-hole/AdminLTE.git
+ local 'str=Check for existing repository in /var/www/html/admin'
+ echo -ne ' [i] Check for existing repository in /var/www/html/admin...'
[i] Check for existing repository in /var/www/html/admin...+ is_repo /var/www/html/admin
+ local directory=/var/www/html/admin
+ local curdir
+ local rc
+ curdir=/home/jxer
+ [[ -d /var/www/html/admin ]]
+ cd /var/www/html/admin
+ git status --short
+ cd /home/jxer
+ return 0
+ echo -e '\r [โ] Check for existing repository in /var/www/html/admin'
[โ] Check for existing repository in /var/www/html/admin
+ update_repo /var/www/html/admin
+ local directory=/var/www/html/admin
+ local curdir
+ local 'str=Update repo in /var/www/html/admin'
+ curdir=/home/jxer
+ cd /var/www/html/admin
+ echo -ne ' [i] Update repo in /var/www/html/admin...'
[i] Update repo in /var/www/html/admin...+ git stash --all --quiet
+ git clean --quiet --force -d
+ git pull --quiet
+ echo -e '\r [โ] Update repo in /var/www/html/admin'
[โ] Update repo in /var/www/html/admin
+ cd /home/jxer
+ return 0
+ echo ''
+ return 0
+ dep_install_list=("${PIHOLE_DEPS[@]}")
+ local dep_install_list
+ [[ true == true ]]
+ dep_install_list+=("${PIHOLE_WEB_DEPS[@]}")
+ install_dependent_packages 'dep_install_list[@]'
+ counter=2
+ [[ 2 == 1 ]]
+ echo -e ' [i] Main Dependency checks...'
[i] Main Dependency checks...
+ argArray1=("${!1}")
+ declare -a argArray1
+ declare -a installArray
+ command -v debconf-apt-progress
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for bc...'
[i] Checking for bc...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' bc
+ echo -e '\r [โ] Checking for bc'
[โ] Checking for bc
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for cron...'
[i] Checking for cron...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' cron
+ echo -e '\r [โ] Checking for cron'
[โ] Checking for cron
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for curl...'
[i] Checking for curl...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' curl
+ echo -e '\r [โ] Checking for curl'
[โ] Checking for curl
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for dnsutils...'
[i] Checking for dnsutils...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' dnsutils
+ echo -e '\r [โ] Checking for dnsutils'
[โ] Checking for dnsutils
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for iputils-ping...'
[i] Checking for iputils-ping...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' iputils-ping
+ echo -e '\r [โ] Checking for iputils-ping'
[โ] Checking for iputils-ping
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for lsof...'
[i] Checking for lsof...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' lsof
+ echo -e '\r [โ] Checking for lsof'
[โ] Checking for lsof
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for netcat...'
[i] Checking for netcat...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' netcat
+ echo -e '\r [โ] Checking for netcat'
[โ] Checking for netcat
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for psmisc...'
[i] Checking for psmisc...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' psmisc
+ echo -e '\r [โ] Checking for psmisc'
[โ] Checking for psmisc
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for sudo...'
[i] Checking for sudo...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' sudo
+ echo -e '\r [โ] Checking for sudo'
[โ] Checking for sudo
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for unzip...'
[i] Checking for unzip...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' unzip
+ echo -e '\r [โ] Checking for unzip'
[โ] Checking for unzip
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for wget...'
[i] Checking for wget...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' wget
+ echo -e '\r [โ] Checking for wget'
[โ] Checking for wget
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for idn2...'
[i] Checking for idn2...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' idn2
+ echo -e '\r [โ] Checking for idn2'
[โ] Checking for idn2
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for sqlite3...'
[i] Checking for sqlite3...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' sqlite3
+ echo -e '\r [โ] Checking for sqlite3'
[โ] Checking for sqlite3
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for libcap2-bin...'
[i] Checking for libcap2-bin...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' libcap2-bin
+ echo -e '\r [โ] Checking for libcap2-bin'
[โ] Checking for libcap2-bin
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for dns-root-data...'
[i] Checking for dns-root-data...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' dns-root-data
+ echo -e '\r [โ] Checking for dns-root-data'
[โ] Checking for dns-root-data
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for resolvconf...'
[i] Checking for resolvconf...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' resolvconf
+ echo -e '\r [โ] Checking for resolvconf'
[โ] Checking for resolvconf
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for lighttpd...'
[i] Checking for lighttpd...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' lighttpd
+ echo -e '\r [โ] Checking for lighttpd'
[โ] Checking for lighttpd
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for php7.0-common...'
[i] Checking for php7.0-common...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' php7.0-common
+ echo -e '\r [โ] Checking for php7.0-common'
[โ] Checking for php7.0-common
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for php7.0-cgi...'
[i] Checking for php7.0-cgi...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' php7.0-cgi
+ echo -e '\r [โ] Checking for php7.0-cgi'
[โ] Checking for php7.0-cgi
+ for i in "${argArray1[@]}"
+ echo -ne ' [i] Checking for php7.0-sqlite3...'
[i] Checking for php7.0-sqlite3...+ grep 'ok installed'
+ dpkg-query -W '-f=${Status}' php7.0-sqlite3
+ echo -e '\r [โ] Checking for php7.0-sqlite3'
[โ] Checking for php7.0-sqlite3
+ [[ 0 -gt 0 ]]
+ echo ''
+ return 0
+ unset dep_install_list
+ [[ true == true ]]
+ enable_service lighttpd
+ local 'str=Enabling lighttpd service to start on reboot'
+ echo -ne ' [i] Enabling lighttpd service to start on reboot...'
[i] Enabling lighttpd service to start on reboot...+ command -v systemctl
+ systemctl enable lighttpd
Ok, so it's definitely not completing correctly.
What is the contents of your lighttpd.conf file? Have you made changes to it since the initial install?
What are the results of systemctl status lighttpd
systemctl status lighttpd
โ lighttpd.service - Lighttpd Daemon
Loaded: loaded (/lib/systemd/system/lighttpd.service; enabled; vendor preset: enabled)
Active: active (running) since Tue 2018-08-07 09:21:02 EDT; 1 day 2h ago
Process: 542 ExecStartPre=/usr/sbin/lighttpd -tt -f /etc/lighttpd/lighttpd.conf (code=exited, status=0/SUCCESS)
Main PID: 667 (lighttpd)
Tasks: 6 (limit: 4915)
CGroup: /system.slice/lighttpd.service
โโ667 /usr/sbin/lighttpd -D -f /etc/lighttpd/lighttpd.conf
โโ703 /usr/bin/php-cgi
โโ708 /usr/bin/php-cgi
โโ709 /usr/bin/php-cgi
โโ710 /usr/bin/php-cgi
โโ711 /usr/bin/php-cgi
Aug 08 04:52:05 PiHole sudo[11146]: pam_unix(sudo:session): session opened for user root by (uid=0)
Aug 08 04:52:05 PiHole sudo[11145]: pam_unix(sudo:session): session opened for user root by (uid=0)
Aug 08 04:52:22 PiHole sudo[11176]: www-data : TTY=unknown ; PWD=/var/www/html/admin/scripts/pi-hole/php ; USER=root ; COMMAND=/usr/local/bin/pihole -q -adlist api.vung
Aug 08 04:52:22 PiHole sudo[11175]: www-data : TTY=unknown ; PWD=/var/www/html/admin/scripts/pi-hole/php ; USER=root ; COMMAND=/usr/local/bin/pihole -q -adlist api.vung
Aug 08 04:52:22 PiHole sudo[11175]: pam_unix(sudo:session): session opened for user root by (uid=0)
Aug 08 04:52:22 PiHole sudo[11176]: pam_unix(sudo:session): session opened for user root by (uid=0)
Aug 08 05:49:13 PiHole sudo[11496]: www-data : TTY=unknown ; PWD=/var/www/html/admin/scripts/pi-hole/php ; USER=root ; COMMAND=/usr/local/bin/pihole -q -adlist aax-us-e
Aug 08 05:49:13 PiHole sudo[11496]: pam_unix(sudo:session): session opened for user root by (uid=0)
Aug 08 05:49:16 PiHole sudo[11511]: www-data : TTY=unknown ; PWD=/var/www/html/admin/scripts/pi-hole/php ; USER=root ; COMMAND=/usr/local/bin/pihole -q -adlist aax-us-e
Aug 08 05:49:16 PiHole sudo[11511]: pam_unix(sudo:session): session opened for user root by (uid=0)
@jxer, could you open a new issue against the pi-hole/Pi-hole repo please? There is something _other_ going on that's causing your particular issue. Cheers
Sorry for the delay...
/etc/.pihole/automated\ install/basic-install.sh : https://pastebin.com/GyE3dDY7
/opt/pihole/update.sh : https://pastebin.com/qv1d9TUh
$ cd /etc/.pihole/ && git status
# On branch master
nothing to commit (working directory clean)
$
@slootsky please try sudo bash -x /etc/.pihole/automated\ install/basic-install.sh --unattended
Seems to have solved issues for others. If it doesn't solve it, please pastebin the output so that we can look further into it.
@PromoFaux That didn't appear to work. Here's the output. https://pastebin.com/9jXn3mw2
and then:
$ sudo pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] FTL: update available
[i] FTL out of date
[i] FTL Checks...
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404
[โ] Downloading and Installing FTL
Error: URL not found
$
I don't know if this is relevant:
$ sudo apt-get upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages have been kept back:
fake-hwclock gnome-accessibility-themes gnome-themes-standard
gnome-themes-standard-data libfm-data libfreetype6 libfreetype6-dev
libgail-3-0 libgcc1 libgfortran3 libgomp1 libgtk-3-0 libgtk-3-bin
libgtk-3-common libjavascriptcoregtk-3.0-0 libpango1.0-0 libstdc++6
libwebkitgtk-3.0-0 lxinput lxpanel omxplayer pcmanfm pypy-upstream zenity
zenity-common
0 upgraded, 0 newly installed, 0 to remove and 25 not upgraded.
Try manually installing the packages: sudo apt install libcap2-bin dns-root-data resolvconf
Hi,
i had the same problem to update from 3.3 to 4.0. i fixed it with the following changes in the automated install/basic-install.sh
diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh
index 10e43b6..0f4df7c 100755
--- a/automated install/basic-install.sh
+++ b/automated install/basic-install.sh
@@ -2025,7 +2025,8 @@ clone_or_update_repos() {
# Download FTL binary to random temp directory and install FTL binary
FTLinstall() {
# Local, named variables
- local binary="${1}"
+ get_binary_name
+ local binary="${binary}"
local latesttag
local str="Downloading and Installing FTL"
echo -ne " ${INFO} ${str}..."
@@ -2274,7 +2275,7 @@ FTLdetect() {
echo -e " ${INFO} FTL Checks..."
if FTLcheckUpdate ; then
- FTLinstall "${binary}" || return 1
+ FTLinstall || return 1
fi
After that change the url is properly generated in basic-install.sh
# If the download worked,
if curl -sSL --fail "${url}/${binary}" -o "${binary}"; then
# get sha1 of the binary we just downloaded for verification.
@Mcat12 I tried that, and it wasn't able to locate the package dns-root-data. This is a call to just update that.
$ sudo apt-get install dns-root-data
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package dns-root-data
$
after installing the others, pihole -up still failed
@mystefix81
Your solution worked for me. I guess there's a bug in basic-install.sh where it is losing the value of ${binary} somewhere along the way, or get_binary_name sometimes doesn't get called before the call to FTLinstall after line 2274. Thank you.
This finally pushed me to just learn/use docker instead. Because of some great people's efforts on https://github.com/pi-hole/docker-pi-hole/issues/299 you can now do swarm deploys on the ARM image.
Made a repo that will use Hypriot to cloud-init an rpi with running pihole in case anyone is interested https://github.com/airbornelamb/rpi
Thanks for everyone's great efforts on this project!
I'm having the same problem.
```# pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] FTL: update available
[i] FTL out of date
[i] FTL Checks...
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL not found
And then in web interface:
``` Pi-hole Version v4.0 Web Interface Version v4.0 FTL Version vDev (master, vDev-8493df4) ```
The web interface is showing 0 domains in the blocklist, but that isn't the case because I see them being blocked in the logs. And then this:
```# pihole -g
[i] Neutrino emissions detected...
[โ] Pulling blocklist source list into range
[i] Target: raw.githubusercontent.com (hosts)
[โ] Status: Retrieval successful
[i] Target: mirror1.malwaredomains.com (justdomains)
[โ] Status: No changes detected
[i] Target: sysctl.org (hosts)
[โ] Status: No changes detected
[i] Target: zeustracker.abuse.ch (blocklist.php?download=domainblocklist)
[โ] Status: No changes detected
[i] Target: s3.amazonaws.com (simple_tracking.txt)
[โ] Status: No changes detected
[i] Target: s3.amazonaws.com (simple_ad.txt)
[โ] Status: No changes detected
[i] Target: hosts-file.net (ad_servers.txt)
[โ] Status: No changes detected
[โ] Consolidating blocklists
[โ] Extracting domains from blocklists
[i] Number of domains being pulled in by gravity: 159005
[โ] Removing duplicate domains
[i] Number of unique domains trapped in the Event Horizon: 135755
[i] Number of whitelisted domains: 163
[i] Number of blacklisted domains: 16
[i] Number of wildcard blocked domains: 0
[โ] Parsing domains into hosts format
[โ] Cleaning up stray matter
[โ] * Starting DNS forwarder and DHCP server dnsmasq
dnsmasq: failed to create listening socket for 192.168.8.2: Address already in use
...fail!
[โ] DNS service is running
[โ] Pi-hole blocking is Enabled
And:
# service pihole-FTL status
[ ok ] pihole-FTL is running
I've tried pihole -r but it doesn't seem to resolve this. It's my understanding that pihole-FTL technically IS dnsmasq, so why is pihole trying to restart dnsmasq instead of pihole-FTL? And I don't understand why it thinks there's an update and yet I can't seem to get pihole to actually update anything.
@XGhozt00 make a new issue
I have the same issue. But solved it by doing
pihole -r
This seems to do the trick of reinstalling everything with current settings while upgrading ftl and disabling dnsmasq.
@mystefix81
Your changes still are not working for me. I now receive the following:
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] FTL: update available
[i] FTL out of date
[i] FTL Checks...
[โ] Detected ARM-hf architecture (armv6 or lower) Using ARM binary
/etc/.pihole/automated install/basic-install.sh: line 2030: binary: command not found
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL not found
The error at 2030 is apparently the line,
local binary="$(binary)"
Any suggestions for what's going wrong?
@BalajiJagadeesan -- this didn't work for me. I was able to get everything "working" but I still get the 404 error.
@AntBand -- This is my exact issue.
I'm trying to update pihole today and getting this issue. Here's the error:
pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] FTL: update available
[i] FTL out of date
[i] FTL Checks...
[i] Downloading and Installing FTL...curl: (22) The requested URL returned error: 404 Not Found
[โ] Downloading and Installing FTL
Error: URL https://github.com/pi-hole/FTL/releases/download/v4.2.3/tbd not found
That URL is not accessible from a browser or from curl manually either. What gives? How do I actually update FTL?
@gladstonedigital make a new issue on https://github.com/pi-hole/pi-hole/. This issue is closed, and this is not the right repo for your issue.
Most helpful comment
Apparently I fixed it, I reran and apt-get update/upgrade...
($) sudo apt-get upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
1 not fully installed or removed.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Setting up resolvconf (1.79) ...
Created symlink /etc/systemd/system/sysinit.target.wants/resolvconf.service โ /lib/systemd/system/resolvconf.service.
Processing triggers for resolvconf (1.79) ...
W: APT had planned for dpkg to do more than it reported back (0 vs 4).
Affected packages: resolvconf:amd64
After this I ran a repair:
pihole -r
Now all is OK:
(root) (Mon Aug 06 10:31:32)
($) pihole -v
Pi-hole version is v4.0 (Latest: v4.0)
AdminLTE version is v4.0 (Latest: v4.0)
FTL version is v4.0 (Latest: v4.0)
(root) (Mon Aug 06 10:31:36)
($) pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] Web Interface: up to date
[i] FTL: up to date
[โ] Everything is up to date!