Fsharp: Red marker on global variable in code that compiles

[forki]

• clone https://github.com/fsprojects/Paket
• run build.cmd

open in VS2017 RC with latest (master) vsix and see verbose is in red:

Interestingly Crtl+F12 works and goes to definition

[vasily-kirichenko]

It's mutable, that's why it's red :)

[vasily-kirichenko]

Please suggest a better color if you have one in mind.

[forki]

ohhh. I thought it's broken. would never assume that this is a feature.

Mhm that color should really be changed.

[vasily-kirichenko]

Yeah. It's really hard to choose a good one. Dark red is just the same as used for strings, for example. If the font is bold, then text moves to the right and left as you type. And so on.

[nosami]

Xamarin Studio default mutable colour

[vasily-kirichenko]

What about white theme? It's quite easy to find a lot of good colors for dark theme.

[TWith2Sugars]

if it was a garish colour (Mangenta for example) it would definitely put me off from using mutable :).

[nosami]

Me and Dave both wanted red, but Miguel was dead set against it :)

[vasily-kirichenko]

What's RGB of it?

[nosami]

Dark theme is #ffd21c, Light theme is #a08000

[vasily-kirichenko]

we cannot provide defaults for dark theme, so the light one is fine :)

[ErikSchierboom]

Perhaps orange is a good suggestion? Is implies a warning (and thus possible danger), but does not imply immediate lethal danger.

[mariusschulz]

It's probably too drastic, but what about giving a different background color to mutable variables?

[nosami]

Dave made Xamarin Studio switch foreground and background colours for a while... looked pretty good everywhere

[majocha]

@vasily-kirichenko

we cannot provide defaults for dark theme, so the light one is fine :)

I was thinking if maybe writing two ready sets of color themes into the settings store during installation would work. We could have nice custom themes out of the box.

[vasily-kirichenko]

@majocha Please, do it if you know how :)

[majocha]

@vasily-kirichenko I have no idea TBH, I would have to investigate this. You probably tried it already?

[vasily-kirichenko]

@majocha No, I've not. What we had in VFPT is a set of colors hard coded in C# source.

[majocha]

@vasily-kirichenko I'll try to tinker with this. If only color settings are accessible programmatically we could check if they exists and otherwise write some defaults for all themes either on install or first run of the package.

[voronoipotato]

Hot pink

[vasily-kirichenko]

@voronoipotato like this?

[vasily-kirichenko]

@nosami #A08000

[vasily-kirichenko]

I think I like #A08000 more.

[vasily-kirichenko]

Fixed in https://github.com/Microsoft/visualfsharp/pull/2448

[voronoipotato]

Haha fair enough, it's a little less offensive on the eyes, while still quite visible :). 👍

[majocha]

I've managed to get the theme manager to build and work so far. What's not cool is that it overwrites user's customizations on every theme change.

[majocha]

@vasily-kirichenko I've revived the theme changer https://github.com/Microsoft/visualfsharp/pull/2450
It's a Frankenstein's monster now but seems to work :)

[majocha]

Fixed with #2450

[vasily-kirichenko]

@nosami point me please at the code which grays out unused open statements (don't tell me you've ported it from VFPT!)

[cartermp]

@vasily-kirichenko Should be in here: https://github.com/mono/monodevelop/blob/master/main/external/fsharpbinding/MonoDevelop.FSharpBinding/HighlightUnusedCode.fs

[vasily-kirichenko]

@cartermp yeah, that's it. It contains quite a lot of interaction with MD editor, so it cannot be copy-pasted as is. I'll try.