Fsharp: [RC3] Inline Rename crashes with MissingMethodException

[vasily-kirichenko]

This is what happens if Inline Rename is enabled:

@Pilchie any ideas? I updated Roslyn packages to the latest available 2.0.0-rc4-61327-05. VS loads slightly older ones:

[vasily-kirichenko]

OK, I tried all 2.0.0-rc4-61324-XX packages available on https://dotnet.myget.org/feed/roslyn/package/nuget/Microsoft.CodeAnalysis and no one contained exactly same binaries as RC3 loads from c:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\ManagedLanguages\VBCSharp\LanguageServices\ (I've compared SHA-1 hashes).

[vasily-kirichenko]

Updating System.Immutable.Collections package to 1.3.1, which is loaded by RC3 has not helped either.

[vasily-kirichenko]

I'm out of ideas.

[cartermp]

@KevinRansom didn't you say that this was caused by an issue with a System.Collections.Immutable version number?

[KevinRansom]

Yes ... it looks that way. We need to ensure that we are using the exact same version as the RTM bits. I seem to recall that Roslyn may have rolled back a change for RC3 ... and we probably didn't. We will have to drill in to see if this issue repro's on RTM. if it does we will need to figure out what to do.

[cartermp]

cc @jasonmalinowski for FYI

[jasonmalinowski]

This is a breaking change that Roslyn did in dotnet/roslyn@806a804bd18c19f39b98871be07241398f6ab7d0. We rolled it back in dotnet/roslyn@96cad53c7a2f7647d7268aaa8bb86c9a7f6473c4 because it broke TypeScript. Upgrading to newer packages and updating code accordingly should be sufficient to unblock this.

[jasonmalinowski]

And yes, the exception is confusing: "missing method" in this case means it can't find the property getter that is matching by return type, since the return type got changed.

[vasily-kirichenko]

As I already wrote, updating System.Immutable.Collections had not helped. Anyone, try it again, maybe I'm doing something wrong.

[cartermp]

@vasily-kirichenko It may require us generating a build with internal bits to get Roslyn references "right". @KevinRansom is looking into doing this over the weekend to see if we can get something working by next week. If we can get a successful build _with no regressions from RC3 + VSIX_, then we'll try to make a case to get this in for RTM...such a change would be subject to review in our shiproom.

[vasily-kirichenko]

@cartermp Interesting thing's just happened: I was on my fix-quick-info branch (which is based on master) and Inline Rename worked OK on RC3 (Ctrl+F5). However, on vs2017-rtm branch it's crashed.

[vasily-kirichenko]

The difference is this:

[vasily-kirichenko]

And of course these

[vasily-kirichenko]

I'm just very surprised that it works with rc2 Roslyn packages, but does not with the latest rc3.

[KevinRansom]

It was explained to me like this ...

• In November Roslyn made an API breaking change.
• F# built against the updated (with breaking change) APIs
• In January the breaking change was rolled back in the RC3 branch.
• We didn't discover that because of the same reason we had to ship the update MSI and VSIX
  separately.

Over the weekend I will update the references to the correct set, re-enable the feature, and hopefully get the change approved for RTM ... however there really is no guarantee of that.

I hope this helps with understanding what has happened.

[vasily-kirichenko]

It may require us generating a build with internal bits to get Roslyn references "right".

Maybe create a sub repository containing proper roslyn binaries, that you at msft could grab directly, no nuget involved, as I suspect do TS and Python teams? I doubt anybody would against it, because the binaries are already published via that myget feed (the problem is that there are no exactly same versions as VS uses).

[KevinRansom]

Everything we need should be published on myget. Roslyn has daily builds pushed to myget. Anyway -I'm not too worried that we can get it sorted now we know what the issue is.

[cartermp]

Because changing Roslyn references to the correct version breaks Find All References, this is going to go into a microupdate for VS 2017. We're too deep into the RTM stabilization period to get the Roslyn references changed, re-enable Inline Rename, address the issue in Find All References, and test again for ensuring there are no regressions in time.

[vasily-kirichenko]

Fixed in master.