Friendica: [2020.06] PHP Notices

[MrPetovan]

Please report here any PHP Notice message obtained running the 2019.12 stable or 2020.03-dev versions.

Follow-up to #8000

[MrPetovan]

https://github.com/friendica/friendica/issues/7677#issuecomment-568059733

By @AlfredSK

Current RC as well:

Undefined index: @context in .../src/Protocol/ActivityPub/Processor.php on line 583

@annando I'm not sure what to do with the missing @context.

[realkinetix]

[04-Apr-2020 17:47:53 UTC] PHP Notice: Undefined index: filename in /home/friendica/friendica/src/Protocol/Email.php on line 258

[realkinetix]

[04-Apr-2020 17:09:10 UTC] PHP Notice: Trying to access array offset on value of type bool in /home/friendica/friendica/src/Model/UserItem.php on line 77

[AlfredSK]

2020.06-dev:

Undefined variable: l10n in .../view/lang/fr/strings.php on line 120
Trying to get property 't' of non-object in .../view/lang/fr/strings.php on line 120

addressed in #8501 and #8502

[AlfredSK]

2020.06-dev:

Undefined variable: xmlhead in .../include/conversation.php on line 240

addressed in #8503

[AlfredSK]

2020.06-dev:

Undefined index: aliases in .../src/Network/Probe.php on line 373

Adressed in #8609

[MrPetovan]

Reported by @copiis in https://github.com/friendica/friendica/issues/8528

PHP Notice: Undefined offset: 400 in /friendica/addon/buffer/bufferapp.php on line 135

[annando]

@copiis what had you tried to do? Buffer had sunsetted its API. So outtages are very likely.

[copiis]

I suspect that at the time I renewed the LinkedIn to Buffer connection. The API still works for me because I have an old app.

[copiis]

[2020.03]

PHP Notice: Trying to get property 'nodeValue' of non-object in /friendica/src/Content/OEmbed.php on line 105

[AlfredSK]

2020.06-dev: A lot of this...
Undefined index: profile_url in ..../src/Module/Directory.php on line 125

Addressed in #8559

[AlfredSK]

2020.06-dev:

PHP Notice:  Undefined index: uri-id in .../src/Protocol/ActivityPub/Processor.php on line 1018

Addressed in #8570

[AlfredSK]

2020.06-dev:
Another notice for 'uri-id'...

Undefined index: uri-id in .../src/Model/Tag.php on line 403

Edit: updated line number (347 -> 345 -> 380 -> 403)

Addressed in https://github.com/friendica/friendica/pull/8633

[copiis]

Geting lot of these on latest develop

PHP Notice:  Undefined index: uri-id in /friendica/src/Protocol/ActivityPub/Processor.php on line 1018
PHP message: PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Friendica\\Model\\Tag::getByURIId() must be of the type int, null given, called in /friendica/src/Protocol/ActivityPub/Processor.php on line 1018 and defined in /friendica/src/Model/Tag.php:320\nStack trace:\n
#0 /friendica/src/Protocol/ActivityPub/Processor.php(1018): Friendica\\Model\\Tag::getByURIId(NULL, Array)\n
#1 /friendica/src/Protocol/ActivityPub/Processor.php(400): Friendica\\Protocol\\ActivityPub\\Processor::getImplicitMentionList(Array)\n
#2 /friendica/src/Protocol/ActivityPub/Processor.php(521): Friendica\\Protocol\\ActivityPub\\Processor::processContent(Array, Array)\n
#3 /friendica/src/Protocol/ActivityPub/Processor.php(222): Friendica\\Protocol\\ActivityPub\\Processor::postItem(Array, Array)\n
#4 /friendica/src/Protocol/ActivityPub/Receiver.php(376): Friendica\\Protocol\\ActivityPub\\Processor::creat...'

Duplicate of https://github.com/friendica/friendica/issues/8475#issuecomment-622606137

[AlfredSK]

@copiis Both (a notice and a fatal) are already reported. The fatal error is already fixed. But the PR isn't merged yet.

[AlfredSK]

2020.06-dev:
Undefined variable: tags in .../src/Protocol/OStatus.php on line 2135

Edit: updated line number is: 2126

There's also a related warning.

Related: https://github.com/friendica/friendica/issues/8474#issuecomment-624157773

Addressed in #8587

[copiis]

2020.06-dev getting lot of these after the last git pull yesterday

PHP Notice: Undefined index: aliases in /friendica/src/Network/Probe.php on line 373'

Adressed in #8609

[copiis]

2020.06-dev

PHP Notice: Undefined index: followers in /friendica/src/Protocol/ActivityPub/Transmitter.php on line 642

Adressed in #8608

[copiis]

2020.06-dev

PHP Notice: Undefined variable: target_item in /friendica/src/Worker/Delivery.php on line 78

Addressed in #8625

[copiis]

2020.06-dev

PHP Notice: Undefined index: tag in /friendica/addon/ljpost/ljpost.php on line 191

Addressed in https://github.com/friendica/friendica-addons/pull/981

[MrPetovan]

Not sure about this one, I thought we kept the virtual item.tag field through the Term -> Tag migration? If not, there are a bunch of other places it still is used.

[annando]

No, we removed that field. I thought to had found any occurrancy.

[MrPetovan]

What should it be replaced with? Tag::getByURIID($item['uri-id'])?

[copiis]

2020.06-dev
PHP Notice: Trying to get property 'nodeValue' of non-object in /friendica/src/Content/OEmbed.php on line 105

[AlfredSK]

2020.06-dev:

Undefined index: service_class in .../src/Module/Settings/UserExport.php on line 146
Undefined index: profile_name in .../src/Module/Settings/UserExport.php on line 118

[copiis]

2020.06-dev

PHP Notice:  Undefined index: gsid in /friendica/src/Protocol/ActivityPub.php on line 174
PHP Notice:  Undefined index: network in /friendica/src/Model/GServer.php on line 472

[AlfredSK]

some 'gravity' related notices in 2020.06-dev:

Undefined index: gravity in .../src/Factory/Notification/Notification.php on line 98
Undefined index: gravity in .../src/Factory/Notification/Notification.php on line 102

and

Undefined index: gravity in .../src/Protocol/DFRN.php on line 963

Addressed in https://github.com/friendica/friendica/pull/8706

[copiis]

2020.06-dev
PHP Notice: Undefined index: subscribe in /friendica/src/Network/Probe.php on line 404

Caused by #8713

Addressed by #8716

[annando]

404? Not found :grin:

[copiis]

PHP Notice: Undefined index: subscribe in /friendica/src/Protocol/ActivityPub.php on line 173

[annando]

@copiis will be fixed by https://github.com/friendica/friendica/pull/8733

[annando]

2020.06-dev:
PHP Notice: Undefined index: REQUEST_URI in /src/Content/Text/Markdown.php on line 51

Addressed in #8755

[MrPetovan]

Hmm, this comes from the Markdown parser where we prepend anchor links with the base URLs. We probably should pass the base URL as an optional Markdown::convert parameter.

[nupplaphil]

Some more gravity PHP Notices:

PHP Notice:  Undefined index: gravity in /var/www/html/src/Protocol/OStatus.php on line 2023

[AlfredSK]

2020.06-RC

Undefined index: url in .../src/Protocol/ActivityPub/Processor.php on line 1007
Undefined index: nurl in .../src/Protocol/ActivityPub/Processor.php on line 1008
Undefined index: alias in .../src/Protocol/ActivityPub/Processor.php on line 1009

[utzer]

2020.06-RC

[19-Jun-2020 08:11:16 Europe/Berlin] PHP Notice:  Trying to access array offset on value of type null in /var/www/src/Model/Item.php on line 3495

[19-Jun-2020 06:14:20 UTC] PHP Notice:  Trying to access array offset on value of type bool in /var/www/src/Protocol/OStatus.php on line 2092
[19-Jun-2020 06:14:20 UTC] PHP Notice:  Trying to access array offset on value of type bool in /var/www/src/Protocol/OStatus.php on line 2093

Addressed in #8790

[AlfredSK]

2020.06-RC: Some notices for the Twitter add-on

Trying to get property 'followed_by' of non-object in .../addon/twitter/twitter.php on line 1056
Trying to get property 'following' of non-object in .../addon/twitter/twitter.php on line 1055
Trying to get property 'id_str' of non-object in .../addon/twitter/twitter.php on line 1112
Trying to get property 'id_str' of non-object in .../addon/twitter/twitter.php on line 1124
Trying to get property 'id_str' of non-object in .../addon/twitter/twitter.php on line 1137
Trying to get property 'screen_name' of non-object in .../addon/twitter/twitter.php on line 1131
Trying to get property 'source' of non-object in .../addon/twitter/twitter.php on line 1055
Trying to get property 'source' of non-object in .../addon/twitter/twitter.php on line 1056
Undefined property: stdClass::$relationship in .../addon/twitter/twitter.php on line 1055
Undefined property: stdClass::$relationship in .../addon/twitter/twitter.php on line 1056

See also https://github.com/friendica/friendica/issues/8474#issuecomment-646803958

Maybe this error from Friendica log is related...

index [ERROR]: DB Error {"code":1136,"error":"Column count doesn't match value count at row 1","callstack":"Database::insert, DBA::insert, twitter_fetch_contact, twitter_follow, Hook::callSingle, Hook::callAll, Contact::createFromProbe, follow_post","params":"INSERT INTO `contact` () VALUES (-1)"} - {"file":"Database.php","line":769,"function":"e","uid":"6b8b3b","process_id":4208}

Addressed in https://github.com/friendica/friendica-addons/pull/991

[AlfredSK]

Some notices for Profile.php in 2020.06-RC:

Undefined index: nickname in .../src/Model/Profile.php on line 333
Undefined index: network in .../src/Model/Profile.php on line 275
Undefined index: nickname in .../src/Model/Profile.php on line 286
Undefined index: network in .../src/Model/Profile.php on line 306
Undefined index: network in .../src/Model/Profile.php on line 307
Undefined index: name in .../src/Model/Profile.php on line 376

Adressed in https://github.com/friendica/friendica/pull/8805

[AlfredSK]

2020.06-rc:

iconv(): Wrong charset, conversion from `maccentraleurope' to `UTF-8//TRANSLIT' is not allowed in .../src/Util/ParseUrl.php on line 217

[MrPetovan]

It seems to be a problem with iconv. See https://github.com/PHPOffice/PhpSpreadsheet/issues/839#issuecomment-471584628 and a possible solution may be to install gnu-libiconv, see https://github.com/docker-library/php/issues/240

[AlfredSK]

Hmm...

iconv support | enabled
iconv implementation | glibc
iconv library version | 2.30

There is no such thing as 'gnu-libiconv' in Ubuntu/Debian. It (libiconv) is part of the libc6 package, which is already installed.

Possibly a PHP bug. All the necessary libraries are installed. There are PHP bug reports about similar issues even for PHP 7.x.

[copiis]

PHP Notice: Undefined index: host in /friendica/src/Worker/UpdateGContacts.php on line 65

[AlfredSK]

2020.06-rc: Is Tumblr still a thing? ;-)

Undefined index: tumblr_page in .../addon/tumblr/tumblr.php on line 302
session_start(): A session had already been started - ignoring in .../addon/tumblr/tumblr.php on line 100
Undefined variable: o in .../addon/tumblr/tumblr.php on line 149
session_start(): A session had already been started - ignoring in .../addon/tumblr/tumblr.php on line 155

[AlfredSK]

I've upgraded to PHP 7.4. I'm getting new notices now. Should I post them here or should I wait for the next release cycle?

[MrPetovan]

Are they deprecation notices?

[AlfredSK]

No. Various notices like this... "Trying to access array offset on value of type null ..."

[MrPetovan]

Then yes.

[AlfredSK]

Ok. Yes to what? :-) Report them now or wait for the next release?

[MrPetovan]

Report them now please, we may not fix them for this release because it still is useful.

[AlfredSK]

Ok. you asked for it. :-) There are more than 200000 lines with notices since I upgraded to PHP 7.4. I sent them through 'sort' and 'uniq'...

2020.06-rc with PHP 7.4

PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 105
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 111
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 114
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 119
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 124
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 129
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 134
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 139
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 143
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 148
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 157
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 161
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 165
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 189
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 197
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 198
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 200
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 201
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 202
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 203
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 204
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 206
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 207
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 88
PHP Notice:  Trying to access array offset on value of type bool in .../src/Module/Xrd.php on line 90
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Nav.php on line 175
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Nav.php on line 176
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Nav.php on line 177
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Nav.php on line 178
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Nav.php on line 183
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Nav.php on line 186
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Nav.php on line 258
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 104
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 106
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 108
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 111
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 112
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 115
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 137
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 163
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 165
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 207
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 235
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 52
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 56
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 57
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 58
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 59
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 91
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 95
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 96
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/Profile/Status.php on line 97
PHP Notice:  Trying to access array offset on value of type null in .../include/conversation.php on line 396
PHP Notice:  Trying to access array offset on value of type null in .../include/conversation.php on line 410
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Widget.php on line 354
PHP Notice:  Trying to access array offset on value of type null in .../src/Content/Widget.php on line 471
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/BaseProfile.php on line 45

Addressed in #8852

PHP Notice:  Trying to access array offset on value of type bool in .../mod/photos.php on line 781
PHP Notice:  Trying to access array offset on value of type bool in .../src/Model/UserItem.php on line 78
PHP Notice:  Trying to access array offset on value of type null in .../include/api.php on line 340
PHP Notice:  Trying to access array offset on value of type null in .../include/api.php on line 347
PHP Notice:  Trying to access array offset on value of type null in .../mod/cal.php on line 125
PHP Notice:  Trying to access array offset on value of type null in .../mod/cal.php on line 129
PHP Notice:  Trying to access array offset on value of type null in .../mod/cal.php on line 131
PHP Notice:  Trying to access array offset on value of type null in .../src/App/Page.php on line 280
PHP Notice:  Trying to access array offset on value of type null in .../src/BaseModule.php on line 111
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/HoverCard.php on line 76
PHP Notice:  Trying to access array offset on value of type null in .../src/Module/HoverCard.php on line 78
PHP Notice:  Trying to access array offset on value of type null in .../view/theme/frio/theme.php on line 231
PHP Notice:  Trying to access array offset on value of type null in .../view/theme/frio/theme.php on line 234
PHP Notice:  Trying to access array offset on value of type null in .../view/theme/vier/theme.php on line 30

Addressed in #8854

[AlfredSK]

Notices with PHP 7.4 were reduced to a large extent. However, there are still some left...

Trying to access array offset on value of type bool in .../src/Module/Diaspora/Fetch.php on line 63

Trying to access array offset on value of type null in .../mod/salmon.php on line 82

Trying to access array offset on value of type null in .../src/Model/Contact.php on line 1094

Undefined index: photo in .../src/Module/Search/Acl.php on line 83
Undefined index: name in .../src/Module/Search/Acl.php on line 84
Undefined index: addr in .../src/Module/Search/Acl.php on line 85
Undefined index: url in .../src/Module/Search/Acl.php on line 85
Undefined index: network in .../src/Module/Search/Acl.php on line 86
Undefined index: url in .../src/Module/Search/Acl.php on line 87

Array to string conversion in .../src/Content/Nav.php on line 190
Trying to access array offset on value of type null in .../src/Content/Nav.php on line 262

Addressed in #8863