Freshrss: Duplicate images

[Cavabanga]

dup images from https://www.yaplakal.com/news.xml

[aledeg]

There's nothing we can do about it. The feed embedded the image and have media files with those same images.
That's why they are displayed twice.

[Alkarex]

If we were to do something, it could be to search whether attachments are already in the body of the article

[thomasrenes]

I see the same thing with other RSS Feeds, it seems easy to work around this by the solution @Alkarex proposes.

Changing this line in Feed.php:
if (strpos($mime, 'image/') === 0) {
to:
if (strpos($mime, 'image/') === 0 && strpos($content, $elink) !== 0) {

Do you guys see any problem with this?

[Alkarex]

@thomasrenes Yes, your proposition seems quite fine to me, although not super robust (e.g. if the link is not as an image, or in a comment, or in plain text, etc.). Could you please make a pull request with your suggestion, so we can discuss it further?

[squromiv]

Could you open it again?Or should i create a new one?

[Alkarex]

@squromiv Re-opened :-)

[serrnovik]

Is there at least quick workaround to this? The issue has been open for quite a while. At least making preference to show attachments as link vs previews would do the trick to my opinion.

update: superfast workaround with custom css (before fix)
.enclosure { float:left; } .enclosure-content { margin:0px; padding:0px; } .enclosure-content video { display:none; } .enclosure-content img { max-width:40px; }

[Dreomite]

This gets even worse with several preview images. (Example: https://backend.deviantart.com/rss.xml?type=deviation&q=by%3Ayuumei+sort%3Atime+meta%3Aall) Is FreshRSS supposed to display all the thumbnails?

Screenshot

<item>
<title>Envision</title>
<link>
https://www.deviantart.com/yuumei/art/Envision-862328723
</link>
<guid isPermaLink="true">
https://www.deviantart.com/yuumei/art/Envision-862328723
</guid>
<pubDate>Thu, 26 Nov 2020 09:40:29 PST</pubDate>
<media:title type="plain">Envision</media:title>
<media:keywords/>
<media:rating>nonadult</media:rating>
<media:category label="Visual Art">visual_art</media:category>
<media:credit role="author" scheme="urn:ebu">yuumei</media:credit>
<media:credit role="author" scheme="urn:ebu">https://a.deviantart.net/avatars/y/u/yuumei.jpg?6</media:credit>
<media:copyright url="https://www.deviantart.com/yuumei">Copyright 2020 yuumei</media:copyright>
<media:description type="html">
<div><span>2020 has been a rough year for everyone. From Covid to the endless wildfires that turned the sky red, sometimes it can feel overwhelming and hopeless. But don't give up, we can envision a better future, and we can bring that vision to life.<br /></span><br /></div><div>For this Thanksgiving, I will be hosting my annual charity art sale to raise money for the environment. Last year we raised $14k in donations and this year MSI&nbsp;will DOUBLE any money we raise! That means if we can raise $15k this year, a total of $30k will be donated! <br /><span></span> </div><div><div><br />The charity sale begins on Nov 27th and will last a whole week. Get 10% off all orders and any print purchase will receive free mystery prints! But best of all is all profits will be donated to charity X2&nbsp;<br /><span>Get your charity art here! </span><span><a href="https://www.deviantart.com/users/outgoing?https://www.yuumeiart.com/shop?fbclid=IwAR28KRLsKTmmmqVgXoinangG125D8d5re-PtQEoIDumvyKAz1hmlLLvgp10"><a class="external" href="https://www.deviantart.com/users/outgoing?https://www.yuumeiart.com/shop">www.yuumeiart.com/shop</a></a></span><br /></div></div><div><div><br />In addition to all that, MSI will also be giving away 6 monitors to anyone who does a good deed (such as helping out the charity sale). Enter here <span><a href="https://www.deviantart.com/users/outgoing?https://us.msi.com/Promotion/yuumei-charity?fbclid=IwAR3w46xxdw9pdKh65IKD35fMGF40DZMXpJeZrrnTxqWukniEDAOl9fi18wM"><a class="external" href="https://www.deviantart.com/users/outgoing?https://us.msi.com/Promotion/yuumei-charity">us.msi.com/Promotion/yuumei-ch&hellip;</a></a></span></div></div>
</media:description>
<media:thumbnail url="https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/454c2ed9-5cc2-484f-8449-167203bd7623/de9ep3n-20a05fc3-c10e-4b4b-8904-4c9c957cb444.jpg/v1/fit/w_150,h_150,q_70,strp/envision_by_yuumei_de9ep3n-150.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOiIsImlzcyI6InVybjphcHA6Iiwib2JqIjpbW3siaGVpZ2h0IjoiPD03MDEiLCJwYXRoIjoiXC9mXC80NTRjMmVkOS01Y2MyLTQ4NGYtODQ0OS0xNjcyMDNiZDc2MjNcL2RlOWVwM24tMjBhMDVmYzMtYzEwZS00YjRiLTg5MDQtNGM5Yzk1N2NiNDQ0LmpwZyIsIndpZHRoIjoiPD0xMjgwIn1dXSwiYXVkIjpbInVybjpzZXJ2aWNlOmltYWdlLm9wZXJhdGlvbnMiXX0.WNC1NwPbZQkvPCRSCFoApKUYyGESNJvNE1nyEWzixsE" height="82" width="150"/>
<media:thumbnail url="https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/454c2ed9-5cc2-484f-8449-167203bd7623/de9ep3n-20a05fc3-c10e-4b4b-8904-4c9c957cb444.jpg/v1/fit/w_300,h_701,q_70,strp/envision_by_yuumei_de9ep3n-300w.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOiIsImlzcyI6InVybjphcHA6Iiwib2JqIjpbW3siaGVpZ2h0IjoiPD03MDEiLCJwYXRoIjoiXC9mXC80NTRjMmVkOS01Y2MyLTQ4NGYtODQ0OS0xNjcyMDNiZDc2MjNcL2RlOWVwM24tMjBhMDVmYzMtYzEwZS00YjRiLTg5MDQtNGM5Yzk1N2NiNDQ0LmpwZyIsIndpZHRoIjoiPD0xMjgwIn1dXSwiYXVkIjpbInVybjpzZXJ2aWNlOmltYWdlLm9wZXJhdGlvbnMiXX0.WNC1NwPbZQkvPCRSCFoApKUYyGESNJvNE1nyEWzixsE" height="164" width="300"/>
<media:thumbnail url="https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/454c2ed9-5cc2-484f-8449-167203bd7623/de9ep3n-20a05fc3-c10e-4b4b-8904-4c9c957cb444.jpg/v1/fill/w_300,h_164,q_70,strp/envision_by_yuumei_de9ep3n-200h.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOiIsImlzcyI6InVybjphcHA6Iiwib2JqIjpbW3siaGVpZ2h0IjoiPD03MDEiLCJwYXRoIjoiXC9mXC80NTRjMmVkOS01Y2MyLTQ4NGYtODQ0OS0xNjcyMDNiZDc2MjNcL2RlOWVwM24tMjBhMDVmYzMtYzEwZS00YjRiLTg5MDQtNGM5Yzk1N2NiNDQ0LmpwZyIsIndpZHRoIjoiPD0xMjgwIn1dXSwiYXVkIjpbInVybjpzZXJ2aWNlOmltYWdlLm9wZXJhdGlvbnMiXX0.WNC1NwPbZQkvPCRSCFoApKUYyGESNJvNE1nyEWzixsE" height="164" width="300"/>
<media:content url="https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/454c2ed9-5cc2-484f-8449-167203bd7623/de9ep3n-20a05fc3-c10e-4b4b-8904-4c9c957cb444.jpg/v1/fill/w_1208,h_661,q_70,strp/envision_by_yuumei_de9ep3n-pre.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOiIsImlzcyI6InVybjphcHA6Iiwib2JqIjpbW3siaGVpZ2h0IjoiPD03MDEiLCJwYXRoIjoiXC9mXC80NTRjMmVkOS01Y2MyLTQ4NGYtODQ0OS0xNjcyMDNiZDc2MjNcL2RlOWVwM24tMjBhMDVmYzMtYzEwZS00YjRiLTg5MDQtNGM5Yzk1N2NiNDQ0LmpwZyIsIndpZHRoIjoiPD0xMjgwIn1dXSwiYXVkIjpbInVybjpzZXJ2aWNlOmltYWdlLm9wZXJhdGlvbnMiXX0.WNC1NwPbZQkvPCRSCFoApKUYyGESNJvNE1nyEWzixsE" height="661" width="1208" medium="image"/>
<description>
<div><span>2020 has been a rough year for everyone. From Covid to the endless wildfires that turned the sky red, sometimes it can feel overwhelming and hopeless. But don't give up, we can envision a better future, and we can bring that vision to life.<br /></span><br /></div><div>For this Thanksgiving, I will be hosting my annual charity art sale to raise money for the environment. Last year we raised $14k in donations and this year MSI&nbsp;will DOUBLE any money we raise! That means if we can raise $15k this year, a total of $30k will be donated! <br /><span></span> </div><div><div><br />The charity sale begins on Nov 27th and will last a whole week. Get 10% off all orders and any print purchase will receive free mystery prints! But best of all is all profits will be donated to charity X2&nbsp;<br /><span>Get your charity art here! </span><span><a href="https://www.deviantart.com/users/outgoing?https://www.yuumeiart.com/shop?fbclid=IwAR28KRLsKTmmmqVgXoinangG125D8d5re-PtQEoIDumvyKAz1hmlLLvgp10"><a class="external" href="https://www.deviantart.com/users/outgoing?https://www.yuumeiart.com/shop">www.yuumeiart.com/shop</a></a></span><br /></div></div><div><div><br />In addition to all that, MSI will also be giving away 6 monitors to anyone who does a good deed (such as helping out the charity sale). Enter here <span><a href="https://www.deviantart.com/users/outgoing?https://us.msi.com/Promotion/yuumei-charity?fbclid=IwAR3w46xxdw9pdKh65IKD35fMGF40DZMXpJeZrrnTxqWukniEDAOl9fi18wM"><a class="external" href="https://www.deviantart.com/users/outgoing?https://us.msi.com/Promotion/yuumei-charity">us.msi.com/Promotion/yuumei-ch&hellip;</a></a></span></div></div><br /><div><img src="https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/454c2ed9-5cc2-484f-8449-167203bd7623/de9ep3n-20a05fc3-c10e-4b4b-8904-4c9c957cb444.jpg/v1/fill/w_300,h_164,q_70,strp/envision_by_yuumei_de9ep3n-200h.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOiIsImlzcyI6InVybjphcHA6Iiwib2JqIjpbW3siaGVpZ2h0IjoiPD03MDEiLCJwYXRoIjoiXC9mXC80NTRjMmVkOS01Y2MyLTQ4NGYtODQ0OS0xNjcyMDNiZDc2MjNcL2RlOWVwM24tMjBhMDVmYzMtYzEwZS00YjRiLTg5MDQtNGM5Yzk1N2NiNDQ0LmpwZyIsIndpZHRoIjoiPD0xMjgwIn1dXSwiYXVkIjpbInVybjpzZXJ2aWNlOmltYWdlLm9wZXJhdGlvbnMiXX0.WNC1NwPbZQkvPCRSCFoApKUYyGESNJvNE1nyEWzixsE" alt="thumbnail" /></div>
</description>
</item>