Freecodecamp: 404 From Lesson Instructions

[benjaminthedev]

The Issue

Whilst going through the ReactJS lessons the link to:

'the way you apply classes to JSX elements.' Isn't working, thus giving a 404. The link it tries to go to is this:

https://www.freecodecamp.org/learn/front-end-libraries/react/learn/front-end-libraries/react/define-an-html-class-in-jsx

I've tested the link in Chrome, Firefox, Safari, Opera, Tor, Chrome Canary and Firefox Dev Edition and same 404.

The lesson:

https://www.freecodecamp.org/learn/front-end-libraries/react/introducing-inline-styles

Screenshots

and:

Cheers!

[raisedadead]

Hey @ojeytonwilliams this looks like a parser issue?

Challenge source: https://raw.githubusercontent.com/freeCodeCamp/freeCodeCamp/master/curriculum/challenges/english/03-front-end-libraries/react/introducing-inline-styles.english.md

This is definitely affecting other challenges.

[raisedadead]

On that note, I think we should update the URL(s) to be

- <a target="_blank" href="learn/front-..."> ... </a>.
+ <a target="_blank" href="/learn/front-..."> ... </a>.

[ojeytonwilliams]

this looks like a parser issue?

The parser doesn't touch anchors (to my knowledge). It's just that that link's relative to the full path, not the domain. So, yeah, as you say: it needs another slash.

[raisedadead]

Okay, thanks for confirming.

Looking at the blame and this seems to have be touched in the past in https://github.com/freeCodeCamp/freeCodeCamp/pull/35125

We should go ahead, audit and update all such links.

[ChristianLapinig]

Hi @raisedadead. I fixed the link to the challenge that @benjaminthedev was referring to. But it sounds like there might be more challenges that might have this problem. Do you want me to help find all the broken links before submitting a PR? Or are you ok with me submitting this for now?

[raisedadead]

Yes, you should add all the changes to your PR. If you work locally using VS Code or any text editor, it should just be a simple search and replace.

For the purposes of QA, I would recommend you make separate PR for different languages (English, Chinese, etc.)

Thanks for working on this.

[benjaminthedev]

Hi @raisedadead and @ChristianLapinig I am happy to keep working through the challenges and finding issues are reporting on GitHub - if you want me to?

[raisedadead]

@benjaminthedev you are welcome to report fresh issues (unrelated to this). I think for this issue, we should be able to do a simple search and replace in the codebase to fix the links :)

[rohit-ambre]

Hi @raisedadead. I fixed the link to the challenge that @benjaminthedev was referring to. But it sounds like there might be more challenges that might have this problem. Do you want me to help find all the broken links before submitting a PR? Or are you ok with me submitting this for now?

I searched learn/ in VS code and found 34 files with such issues where it requires / at start.
There can be more if I have missed anywhere

[DConstantine9]

Hey guys! I'm new in open source projects and I want to ask you how can I find a file where a bug is? Thanks. have a good day

[ahmadabdolsaheb]

@DConstantine9 please go to the following link and click on the green "New Issue" button
https://github.com/freeCodeCamp/freeCodeCamp/issues

[raisedadead]

@ahmadabdolsaheb I think they are seeking to contribute to the repo.

@DConstantine9 you should follow the contributing guidelines mentioned in the read me.

[AshNaz87]

@raisedadead Has this been done?

If not, am happy to submit a PR