Freecodecamp: React migration for componentWillMount

Created on 19 Sep 2019  路  5Comments  路  Source: freeCodeCamp/freeCodeCamp

image

We need to migrate and move away to the recommendation as per the logs above.

help wanted client

Most helpful comment

@raisedadead oh, it'd be a massive pain to migrate, for sure. What I should have said was "the solution is going to be to migrate away from the current version of react-bootstrap". To be honest, it's always seemed a bit out of place.

All 5 comments

So far I've found that react-instantsearch-dom and @freecodecamp/react-bootstrap are the main culprits. Possibly also @reach/router.

Algolia seem to be working on this:
https://github.com/algolia/react-instantsearch/issues/1743

As for @freecodecamp/react-bootstrap I suspect the solution is going to be to migrate to a more recent version of react-bootstrap.

I'll take a closer look at this next week, but if anyone feels like investigating, please do!

the solution is going to be to migrate to a more recent version of react-bootstrap.

Let's ditch that, for good. We do not need the full library. Also if I am not mistaken we are not on v4 yet. It will be a huge pain to go that route

@ahmadabdolsaheb and I have been talking about this a lot. I think we should just move to CSS-in-JS solution like theme-ui or something.

Its way lightweight that the bulky bootstrap lib.

@raisedadead oh, it'd be a massive pain to migrate, for sure. What I should have said was "the solution is going to be to migrate away from the current version of react-bootstrap". To be honest, it's always seemed a bit out of place.

It seems like upgrading to the beta version of Algolia Instantsearch will prevent these errors: https://github.com/algolia/react-instantsearch/issues/2813#issuecomment-527179701, https://github.com/algolia/react-instantsearch/issues/2836.

Should we move to the beta version for now, then upgrade once the stable version is released?

Should we move to the beta version for now, then upgrade once the stable version is released?

Sounds good to me. If we do that and migrate away from react-bootstrap, it should also make it easier to find where else those methods are being used. I.e. when we don't have to sift through a cloud of other warnings.

Was this page helpful?
0 / 5 - 0 ratings