Freecodecamp: [beta] remove <hr>'s above footer?

Created on 15 Feb 2019  路  4Comments  路  Source: freeCodeCamp/freeCodeCamp

In my opinion, I don't like the hr's above the footer - specifically on the curriculum page, but it might look better without it all around. It just looks a little out of place or something to me.

screen shot 2019-02-15 at 10 36 43 am
screen shot 2019-02-15 at 10 36 14 am

Most helpful comment

I agree, the thing is, without it the lessons would look strange. it looks like the instructions fade into space. so the best way would be to add lower border to the challenges on learn and completely remove the hr tag.

All 4 comments

I agree, the thing is, without it the lessons would look strange. it looks like the instructions fade into space. so the best way would be to add lower border to the challenges on learn and completely remove the hr tag.

There was a new addition to the lessons and all of the buttons are placed at the bottom of the view. So it would probably be safe to just remove the hr. But be wary of how it would look on the guide.

I have something in works about this. See linked PR.

the above-mentioned pr (#35235) closes this issue.

Was this page helpful?
0 / 5 - 0 ratings