I was doing the CSS tutorial and when did a mistake on assinging the value of a css variable I got an error on the console and the message on the console is "penguin class should declar the --penguin-skin variable and assign it to gray." and you can see the there is a spelling mistake. 'declar' should be 'declare'.
@Twaha-Rahman Hi Twaha, the spelling of grey as gray is not a spelling mistake, it is a valid way of spelling the color as depending if you are using UK English (grey) or US English (gray). Both are accepted by W3 standard and in the lessons US spelling is used.
@mstellaluna I think @Twaha-Rahman was referring to the typo in "declar" not "gray".
'declar' should be 'declare'.
Could i make a pull request? (my first ever) and fix this typo? =)
@clarkngo Sorry, looks like someone fixed it already (https://github.com/freeCodeCamp/freeCodeCamp/pull/17355)
\cc @ahmadabdolsaheb
I think I've found it, but someone had beat me to it.
As a learning experience, though, I wonder if I did the right thing:
I opened the link to the page with the error, went to the dev tools, looked at the sources and figured where it's called from, generally.
Than I found a json file corresponding to that name and found the exercise as an object.
I think I found the right place (responsive-web-design-01/basic-css,json), but am I right? If so, is there a better way to go about it?
Thanks!!
@wildhamster26 I'm not sure whom you were asking, but I'm going to answer anyway.
Yes, if I'm totally new to the app, that's what I would do, too,.
However, if you setup the app on your local machine, looking things up will get easier and cooler.
I got this repo running locally already, all I need to do is to use the git grep <string>
command, it will find all the files that contain the string and give them to me (I used the -w
option to match the exact word, otherwise, it'll look for declare
too):
Neat huh?
Anyway, I love your learning spirit! Thanks for taking the time to investigate the issue. As the curriculum has grown significantly, I'm sure there are still plenty bugs and typos waiting for us to catch. Hope you can get a chance to contribute soon!
oh that's fine :) i'll have my chance sooner or later. @huyenltnguyen
@huyenltnguyen - Thanks for that great search option. Already put it to use - Much easier! :)
Also thanks for the encouragement. It means a lot to a noob line me. :)
Have a great day.
then this issue should be closed since already solved?
@Bouncey @raisedadead @ahmadabdolsaheb Please close this issue. It has been fixed for a long time.
Thanks @anku255
Most helpful comment
@clarkngo Sorry, looks like someone fixed it already (https://github.com/freeCodeCamp/freeCodeCamp/pull/17355)
\cc @ahmadabdolsaheb