Freecodecamp: clicking outside of search results should collapse search results

[QuincyLarson]

[TomerPacific]

@jonathan-grah ,
is this still relevant? I would like to fix it.

[jonathan-grah]

@TomerPacific, yes! Go ahead, feel free to tag me for a review 😃

[TomerPacific]

@jonathan-grah ,
I'm on it.

UPDATE - 23.11.18
Having issues with setting up a local development environment. Will update if I won't be able to overcome these issues after the weekend

[QuincyLarson]

@TomerPacific Have you had a chance to look into this further? We'd still appreciate your help with this :)

[TomerPacific]

@QuincyLarson ,
still having issues with local development environment. Got wrapped up in other things and forgot to update. If anyone wants to deal with this issue, please go ahead.

[QuincyLarson]

@TomerPacific Thanks! If you have time to get your local dev environment working, and want to tackle this, please let us know here on this GitHub issue.

I've assigned the "Help Wanted" label so this is open to anyone interested in tackling it.

[kanpeki]

@jonathan-grah Hi, I would like to take a look at this. I've managed to set up the env, but I have a question regarding the expected behaviour: should the search bar clear when clicking outside the search results, besides the hits window closing?

[jonathan-grah]

@kanpeki, no I don't think we should clear the search bar, let's keep it as it is for now 👍 Thanks for your help, let me know if you need any help 😄

[QuincyLarson]

@kanpeki We would welcome your help with this!

I agree with @jonathan-grah - when a user clicks outside of the results, we should should just close the search bar dropdown and leave their current query string as is in there.

[hilliarj]

@kanpeki Are you still working on this? I would like to try to see if I could fix this as well.

[thesidbatra]

@Bouncey https://github.com/freeCodeCamp/search-assets/pull/11 can you update the semantic version of search-assets to 2.0.3 and publish the module? because these latest changes can't be seen

[jragard]

I can't reproduce the persistent dropdown menu in my local environment (just got the docker build up and running yesterday), but I can see that it still won't go away on the live site.

[danyalasif]

@jragard Tested it on gitpod local environment, works as intended. Still does not work on live site.

The search width is too wide too, so it's not working responsively either.

[ahmadabdolsaheb]

this issue has been resolved in the new site. thank you all for reporting and contributing to resolve this issue.