Freecodecamp: challenge description and solution needs updating to align with MDN best practice

Created on 18 May 2018  路  7Comments  路  Source: freeCodeCamp/freeCodeCamp

Challenge: "Basic HTML and HTML5 - Create a Set of Radio Buttons"
https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/create-a-set-of-radio-buttons

Here is the relevant text in the description for this challenge:

Each of your radio buttons should be nested within its own label element. Wrapping an input element inside of a label element makes the label text clickable.

It is NOT necessary to wrap an input element inside of a label element to make the text clickable as long as there is a for field on the label that matches the id of the input. The recommendation on fCC is contrary to what is shown at MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/radio

Same for checkboxes. This should be changed as well to match best practices shown on MDN.

It works either way so this is not necessarily an error but I think it is best to change this to go along with MDN.

help wanted learn

Most helpful comment

And to further clear any confusion log any issue on any of the repositories.

We (@freeCodeCamp/moderators) will take care of moving them around as needed. There is a chrome extention that makes this as simple as clicking a few buttons.

All 7 comments

@beaucarnes Hi. Since this one is for learn, do you want to close this one out and re-open it on the learn repo? I can quickly do it if you're not available.

I initially had it on learn and was told to close it out and open here. 馃榾
https://github.com/freeCodeCamp/learn/issues/42

@beaucarnes 馃槃

To clear any confusion, curriculum issues belong here, platform issues belong in the learn repo.

We will be publishing the seed files as an npm package shortly, so the seed files held in learn will no longer exist

And to further clear any confusion log any issue on any of the repositories.

We (@freeCodeCamp/moderators) will take care of moving them around as needed. There is a chrome extention that makes this as simple as clicking a few buttons.

@beaucarnes Would you be interested in updating this challenge real quick to bring it into line with best practices?

@beaucarnes I can take care of this. I have looked through the freecodecamp repo and learn repo but did not see where the curriculum is located at though. Must be overlooking it?

Upate: Found it ha ha

Was this page helpful?
0 / 5 - 0 ratings