Freecodecamp: [Beta] All API and Microservice Projects pass for any url submission

Created on 6 May 2018  路  13Comments  路  Source: freeCodeCamp/freeCodeCamp

help wanted learn projects-frontend critical path

Most helpful comment

@Em-Ant, I can confirm the file metadata tests work on earlier versions of Internet Explorer, with testing, so these tests should be good to go! I can create a PR for these if your too busy. I'm not sure what you mean by the tests not being accurate enough on the tests glitch, I'm unable to see a better way of testing this behaviour.

All 13 comments

/cc @tchaffee @Em-Ant

Hello. Sorry If I made you wait a bit. I had a look, and unfortunately there are no tests for the microservices in the seed files.
Some test strings can be found in my 'app tester' glitch project https://glitch.com/edit/#!/narrow-plane?path=public/tests.js:141:2 . They work but they are not 100% complete. If someone can add them to the seed file it's better. I can do it, but it will take a while. I'm quite busy in this period.

@Em-Ant Thanks for the details. How soon do you think you'd be able to do this?

I could add the few that we have on the test boilerplate quite soon, but those tests are not enough for all the microservices (they cover 100% of timestamp and we have a proof of concept for the others). I'd like to have some help on this.

I submitted a PR to the curriculum with the tests for the timestamp microservice https://github.com/freeCodeCamp/curriculum/pull/99 .

I'll try to add all the tests that I have ready, even if they are not complete. It's better than having nothing.

Tests for API and Microservice Projects

  • [x] Timestamp Microservice
  • [ ] Request Header Parser Microservice
  • [ ] URL Shortener Microservice
  • [ ] Exercise Tracker
  • [ ] File Metadata Microservice

@Em-Ant Thanks for fixing the timestamp microservice challenge. Have you had a chance to look at the other ones?

@QuincyLarson sorry for the late response. No I didn't, I was waiting for @jonathan-grah to have a look.
I could add a couple of other tests, but I have some technical questions about how the testing works in the source code. Who can I ask ?

@Em-Ant, I can confirm the file metadata tests work on earlier versions of Internet Explorer, with testing, so these tests should be good to go! I can create a PR for these if your too busy. I'm not sure what you mean by the tests not being accurate enough on the tests glitch, I'm unable to see a better way of testing this behaviour.

@jonathan-grah sorry I'm quite busy this month, please open a PR. My main concern was not about file metadata (even if it uses the new fetch api to simulate a file uplad). The url redirect needs other glitch projects running to check if the redirect works, and both that one and the exercise tracker would need to store something in a global object to pass the data across tests. I don't know if it's allowed in the freecodecamp source.

@jonathan-grah Sounds good. Thanks for looking into this and looking forward to your PR :)

I have just started back to school, with a new curriculum etc., which will be demanding for the next while, and @Em-Ant seems quite busy, so maybe a more active and available contributor would be able to chime in and help?

Closing this in favor of #35054

This has come up many times and I think we cannot check all the projects, since we do allow people to submit any project in any language of their choice.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vaibsharma picture vaibsharma  路  3Comments

trashtalka3000 picture trashtalka3000  路  3Comments

danielonodje picture danielonodje  路  3Comments

jurijuri picture jurijuri  路  3Comments

raisedadead picture raisedadead  路  3Comments