Freecodecamp: Audit codebase to make sure all relative protocol URLs start with "HTTPS"

Created on 18 Jan 2018 · 9Comments · Source: freeCodeCamp/freeCodeCamp

We have been using and recommending protocol relative URLs like so:

<script src="//code.jquery.com/jquery-2.2.3.min.js"></script>

This was made popular by:
https://www.paulirish.com/2010/the-protocol-relative-url/

But, I believe, this something we should be NOT be doing now on, since the author have long since updated their advice.

More reference: https://jeremywagner.me/blog/stop-using-the-protocol-relative-url/

Hence we need to audit our code-base for such uses, list them here and update the links after confirmation.

Original seen in https://github.com/freeCodeCamp/freeCodeCamp/pull/16488#issuecomment-358730193

first timers only help wanted

Source

raisedadead

Most helpful comment

I'm for making cdn links explicitly https.

BerkeleyTrue on 19 Jan 2018

👍4

All 9 comments

/cc @freeCodeCamp/moderators

raisedadead on 18 Jan 2018

@raisedadead I agree with Paul Irish's logic here. @BerkeleyTrue what do you think? Should we create an issue to go through and turn these relative URLs into https URLs?

QuincyLarson on 19 Jan 2018

Note, this should only be done for URLs that we can confirm are served over https already.

raisedadead on 19 Jan 2018

I'm for making cdn links explicitly https.

BerkeleyTrue on 19 Jan 2018

👍4

@raisedadead @BerkeleyTrue Sounds like a plan!

I've updated the issue title and added the Help Wanted label.

QuincyLarson on 22 Jan 2018

@LorenpNYC on github when you're looking at this issue go to the top of your page and find this button:
screen shot 2018-01-21 at 9 44 46 pm
Change it to ignore or Not watching