Freecodecamp: Update beta lesson buttons to match production

Created on 22 Dec 2017  路  11Comments  路  Source: freeCodeCamp/freeCodeCamp

We need to update beta's lesson buttons to match production's. Here's a screenshot with additional detail:

generate_random_whole_numbers_with_javascript___freecodecamp_and_learn_to_code___freecodecamp

help wanted

All 11 comments

@QuincyLarson I'll work on this one.

@KhaledSamir Awesome - thanks for grabbing this one! Please keep us posted and let me know if I can do anything to help :)

@QuincyLarson Sure ... I'll keep you posted!

Hey @QuincyLarson, I'm done with the required changes and get the html exactly matches the production but I have a question. When we click on " Ask for help on the forum " , the modal that will pops-up is still different So, do you wanna fix this as part of this issue or open a new one specifically for the modal?

This is in Local ( Check the buttons also :) )

screen shot 2017-12-22 at 7 16 38 pm

This is in Production

screen shot 2017-12-22 at 7 20 17 pm

@Kalcode Yes - good catch! Can you also update that modal?

@QuincyLarson sure, I'll give it a try tomorrow morning.

Wrong user mention :)

Thought you were randomly asking me to update something. I was like sure I'll look into it lol.

@Kalcode Woops. You are super active on GitHub - I guess that's why it auto-completed to you. We'd welcome your help in general though :)

@KhaledSamir OK - thanks for your help with this!

@QuincyLarson GM! , I checked the changes that should be done and I'd say it's better to have separate issue for changing the modal and here's why.

There is a file called " ns.json " in this path " Common/app/routes/Challenges " and we load the name of the classes "css classes I mean " with the value of this file which is currently " Challenges "
and if we just change it to " Challenge " the header would turn green like the production but since this change is gonna impact other files " not just Bug-Modal.jsx " so, I'll prefer to open another issue to fix that and make sure that other views don't get impacted by this change.

Second reason is : the content of the modal seems like changed in production and I thought as well so, I think we'll need also to address that.

Let me know what you guys think.

@KhaledSamir Awesome! I agree with your reasoning here. Would you be interested in opening that second issue, and then opening a second pull request as well?

@QuincyLarson Yup, I'll open another issue and put my findings there. I'll work on the other issue tomorrow.

Was this page helpful?
0 / 5 - 0 ratings