Freecodecamp: [beta][UI][accessibility] icon color change for challenges
The icon color for the challenges, testing div
div.challenge-test-suite
has a color that is not accessible at#d9edf7
Please change to the default color of darkgreen
tommygebru
All 9 comments
Changed the color in the challenge.less file. Making a PR now :)
.refresh-icon {
color: darkgreen;
}
Ethan-Arrowood
on 28 Feb 2017
Hi all! @tommygebru
I agree, the current version of the icon has a too light grey. However, I think changing it to green isn't great UX.
I'm used to all green tests meaning that I passed the tests.
What do you think about changing it to a darker blue or grey? #1d6280 is a dark shade of the current blue that gets a AAA from the WCAG guidelines. #575757 is the lightest shade of grey that would pass. I think a shade of grey looks better than a dark blue in this case.
@Ethan-Arrowood Are you up for changing this again?
systimotic
on 2 Mar 2017
Yes I'll make it happen today 😄
Ethan-Arrowood
on 2 Mar 2017
How does this look?
Ethan-Arrowood
on 3 Mar 2017
@Ethan-Arrowood Can you try a shade of grey as well? I think it would look better, as it's more similar to the text. We don't want this icon to stand out too much.
systimotic
on 3 Mar 2017
I like the grey more. What do you think @systimotic?
Ethan-Arrowood
on 3 Mar 2017
@Ethan-Arrowood I like the grey!
Greenheart
on 3 Mar 2017
@Ethan-Arrowood Agreed! I definitely like the grey more as well. Can you submit a PR?
systimotic
on 3 Mar 2017
Will do after class.
On Fri, Mar 3, 2017 at 11:23 AM Timo notifications@github.com wrote:
@Ethan-Arrowood https://github.com/Ethan-Arrowood Agreed! I definitely
like the grey more as well. Can you submit a PR?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/12844#issuecomment-283998860,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APZXHtEQxvXDCC5cPDXLfnpOw905CROlks5riD6egaJpZM4Lt1-j
.>
Ethan Arrowood
Computer Science - WIT 2020
Applied Mathematics & Business Management
ethan.[email protected] | 609.276.4043
ethanarrowood.com | @arrowoodtech
Ethan-Arrowood
on 3 Mar 2017
Related issues
tchaffee
·
40Comments
doubleUTF
·
45Comments
QuincyLarson
·
114Comments
Ethan-Arrowood
·
56Comments
povilasraciunas
·
59Comments
Most helpful comment
Will do after class.
On Fri, Mar 3, 2017 at 11:23 AM Timo notifications@github.com wrote:
Ethan Arrowood
Computer Science - WIT 2020
Applied Mathematics & Business Management
ethan.[email protected] | 609.276.4043
ethanarrowood.com | @arrowoodtech