Freecodecamp: Incorrect answer passes Challenge Record Collection

Created on 11 Oct 2016  路  1Comment  路  Source: freeCodeCamp/freeCodeCamp

Challenge Record Collection has an issue.
My code below passes this challenge, but it's not actually right since it directly assigns to artist property.
collection[id].artist = value;
should be
collection[id][prop] = value;

My code:

// Setup
var collection = {
    "2548": {
      "album": "Slippery When Wet",
      "artist": "Bon Jovi",
      "tracks": [ 
        "Let It Rock", 
        "You Give Love a Bad Name" 
      ]
    },
    "2468": {
      "album": "1999",
      "artist": "Prince",
      "tracks": [ 
        "1999", 
        "Little Red Corvette" 
      ]
    },
    "1245": {
      "artist": "Robert Palmer",
      "tracks": [ ]
    },
    "5439": {
      "album": "ABBA Gold"
    }
};
// Keep a copy of the collection for tests
var collectionCopy = JSON.parse(JSON.stringify(collection));

// Only change code below this line
function updateRecords(id, prop, value) {
  if (value === "")
    delete collection[id][prop];
  else  if (prop !== "tracks")
    collection[id].artist = value;
  else {
    if (! collection[id].hasOwnProperty("tracks"))
      collection[id].tracks = [];
    collection[id].tracks.push(value);
  }


  return collection;
}

// Alter values below to test your code
updateRecords(5439, "artist", "ABBA");


discussing

Most helpful comment

@bilgiprog Good catch; we should probably add a tests that ensures this code won't pass. It could be something like:
updateRecords(1245, "album", "Riptide")

What do others think? I can do the PR to add the test.

>All comments

@bilgiprog Good catch; we should probably add a tests that ensures this code won't pass. It could be something like:
updateRecords(1245, "album", "Riptide")

What do others think? I can do the PR to add the test.

Was this page helpful?
0 / 5 - 0 ratings