Freecodecamp: Remove obsolete dependencies from package.json

[bugron]

Since we don't use it anymore.

Update: -by @raisedadead:
Issue mods do not close this in a merge. Lets keep this a recurring open issue for first timers.

[bugron]

We also seems don't use cheerio, nodemailer-ses-transport, react-toastr, sanitize-html, url-regex, xss-filters, gulp-dest, happy, loopback-testing, jquery npm package, @BerkeleyTrue, @raisedadead please, confirm.

[raisedadead]

thanks for the issue, will have a look and get back

[kaylegh]

I removed the conresponding line, and wait for @raisedadead return

[raisedadead]

| Checked | Package | Required |
| --- | --- | --- |
| | cheerio | NO - Please remove |
| Checked, dependency for loopback | nodemailer-ses-transport | YES - Do NOT remove |
| | react-toastr | NO - Please remove |
| not yet | sanitize-html | |
| not yet | url-regex | |
| not yet | xss-filters | |
| not yet | gulp-dest | |
| | happy | NO - Please remove |
| | loopback-testing | NO - Please remove |
| not yet | jquery | |

[raisedadead]

Will update when I can, but @BerkeleyTrue has to sign off on this.

[bugron]

@raisedadead don't you need to import or require (according to docs) nodemailer-ses-transport somewhere to actually use it or it's plugged in automatically?

[BerkeleyTrue]

@bugron A lot of modules are automatically imported by loopback.

What the hell is happy?

[bugron]

@BerkeleyTrue cool, just wanted to confirm (all other packages used by loopback either are imported/required or are specified in middlewares json file).
https://www.npmjs.com/package/happy

[BerkeleyTrue]

react-toastr, cheerio, happy and loopback-testing should be removed.

[iamrudra]

I can take this one.

[shreya22]

hello everybody. m struggling with my first time contribution in opensource. one query.. when we see an open issue, we work towards it. but there may be many more working on the same thing. so, is it like a matter of time, the one submitting fast as soon as its open will be considered first and may win..?
thanks :)

[raisedadead]

Hi @kaylegh @iamrudra and @shreya22, thanks for responding, and welcome to contributing to Free Code Camp. Glad to know that you are fired up for taking this up, and making it hard for us to decide :stuck_out_tongue_winking_eye: , so here is what we will do:

Each contributor can take up just one dependency that has been confirmed for removal. Comment below who;s gonna take what.

I think @kaylegh already has made a commit, so async has been done. Others please choose yours.
Make sure you go through the Guidelines for Contributing and refer especially on how to create a pull request.

Most importantly do not include issue nos anywhere, and in this particular case you can ignore the closes tag for the PR description.

Thanks a lot and happy fixing!

P.S: Reachout to the Contributors Chat room.

[shreya22]

i am taking this

[iamrudra]

@raisedadead - I will remove - react-toastr, cheerio. You said one but I guess we have 4 to divide between myself and @shreya22. Let me know if you strictly want me to take one.

[wskinner74]

Well, I'll jump in as well, new to open source contributions as well. I'll take loopback-testing

[abhisekp]

npm-check is a nice command line app to automagically :sparkles: report unwanted packages and can be used to remove them easily.

[BerkeleyTrue]

@abhisekp Yes, that is a great project, but it gives a lot of false positives with applications that dynamically require modules like loopback does.

[raisedadead]

Hey guys! Thanks a lot for your willingness to contribute, we are glad to hear about your enthusiasm.

Here's what we precisely want to avoid any confusions, but first we want you to understand that we look forward to every one's contribution, the point being, we are not looking for the fastest contributor, but more contributors who actually understand the process.

So, for now among the already identified packages, please take this in the following order:

1. @kaylegh please open a pull request if you are ready for async
2. @iamrudra : just one package this time, please open a PR for react-toastr, request you to check loads of open issues marked help wanted
3. @shreya22 please open a pull request for cheerio
4. @sync350 yup loopback-testing is all yours.

Reach out to the Contributors chat should you need any further clarification.

[iamrudra]

@raisedadead - I really love the spirit here - Divide the trivial task among first timers to motivate them and get a rub of how open source works. I must say FCC is one of the best communities that I've seen.

[iamrudra]

• [x] First PR towards FCC :smiley:

[BerkeleyTrue]

Closing in favor of #10395