Freecodecamp: Change infinite loop detected message

Created on 18 Dec 2015 · 6Comments · Source: freeCodeCamp/freeCodeCamp

When a user tries their code with a long running loop message only warns them of an infinite loop detection.

We should change this message so that it lets them know how to disable it if needed. This will hopefully reduce the number of issues we get when there is a valid long running loop.

The message can be changed here:
https://github.com/FreeCodeCamp/FreeCodeCamp/blob/staging/client/commonFramework/add-loop-protect.js#L8

Source

BerkeleyTrue

Most helpful comment

@SaintPeter, that kind of comment has no place in open source, and certainly no place on a FreeCodeCamp repo (I'm sure @QuincyLarson would agree). It's been several months since your comment. I hope this behavior is behind you. I'm sure it's against the FreeCodeCamp code of conduct. Please keep the open source and FreeCodeCamp community friendly and welcoming to newcomers.

kentcdodds on 2 Sep 2016

👍38 ❤1

All 6 comments

Hey, I'd like to work on this. How can the message be altered to accommodate the changes you propose?

shubheksha on 19 Dec 2015

@shubhekshajalan If you can't figure out how to make the change, you're not qualified to make the change. The file is linked above. Feel free to give it a go, but the whole point of "help wanted" is that you make and test the change yourself.

SaintPeter on 19 Dec 2015

👎40

@SaintPeter I think @shubhekshajalan is asking what the message should look like, not how to change the message.

BerkeleyTrue on 19 Dec 2015

Just submitted a PR for this: https://github.com/FreeCodeCamp/FreeCodeCamp/pull/5378

geoff616 on 19 Dec 2015

kentcdodds on 2 Sep 2016

👍38 ❤1

@kentcdodds Thanks for bringing this to my attention. This is the first time I'd seen this issue.

@shubheksha Sorry about @SaintPeter's discouraging comment. I think he misunderstood you. Either way, he shouldn't have responded so briskly and unconstructively.

@shubheksha If you're still open to contributing to our open source project, we would welcome your contributions, and I'll do everything I can to remove any obstacles or ambiguities you encounter.