Framework: URLGenerator is not getting app.url from config

Created on 21 Apr 2020 · 6Comments · Source: laravel/framework

Versions

Laravel Version: 7.7.0
PHP Version: 7.4.0

Description

Looks like the URLGenerator is not getting the app.url from the app container.

Steps To Reproduce

> php artisan tinker
Psy Shell v0.10.3 (PHP 7.4.0 — cli) by Justin Hileman
>>> config('app.url')
=> "http://laravel.com"
>>> config()->set('app.url', 'http://spatie.be');
=> null
>>> config('app.url')
=> "http://spatie.be"
>>> url('/random')
=> "http://laravel.com/random"
>>>

needs more info

Source

antonioribeiro

👍2

Most helpful comment

@driesvints , yeah, that works fine. So maybe we could raise an exception when someone tries to set app.url at runtime? Because looks like, somehow, this works sometimes. I actually found that working on a Spatie package, one the tests were failing because of this, but the one on master is probably passing fine.

Thank you!

antonioribeiro on 21 Apr 2020

👍2

All 6 comments

Can confirm.

Laravel 7.7.0
PHP 7.4

nnerijuss on 21 Apr 2020

could you try config clear before using url(), maybe url generator is generating route based on cached root

illuminate\Routing\UrlGenerator::class : line 61
/**
 * A cached copy of the URL root for the current request.
 *
 * @var string|null
 */
protected $cachedRoot;

onetwothreeneth on 21 Apr 2020

We removed the behavior of setting the app url through the config in https://github.com/laravel/framework/pull/32345 because we want to let the router take care of setting the url. The previous behavior was actually sort of work around for an old issue. This wasn't documented either.

We actually have a dedicated way for the router to set the base url for routing which is URL::forceRootUrl('http://api.app.test');. Can you try that?

driesvints on 21 Apr 2020

Thank you!

antonioribeiro on 21 Apr 2020

👍2

Hey guys!
Just saw this by pure luck and got a little worried because we're doing this in a Laravel 6 app that we're going to upgrade to Laravel 7 in the coming weeks.

But I think we're already covered. Is there any difference between this two?
A. URL::forceRootUrl('http://api.app.test')
B. app('url')->forceRootUrl('http://api.app.test')

We also set the app.url a line after the app('url')->forceRootUrl(...