Framework: Storage::download not working with S3

[caseydwyer]

• Laravel Version: 6.16.0
• PHP Version: 7.3.8
• Database Driver & Version: N/A

Description:

The Storage::download method seems broken. Might be an issue with flysystem-aws-s3-v3, but thought I'd start here.

Steps To Reproduce:

1. Fresh Laravel install.
2. composer require league/flysystem-aws-s3-v3 ~1.0
3. Enter S3 credentials into .env
4. Route for downloading an existing, public file. eg:

return \Storage::disk('s3')->download( '/_testing/sample-image.jpg' );

1. Observe failed download.

[driesvints]

Wondering if it's related to https://github.com/laravel/framework/pull/31163

Does downgrading to v6.11.0 fix the problem? And if so: does upgrading to v6.12.0 break it again?

[voyula]

Please give Laravel error logs file content.

[caseydwyer]

@driesvints - Thanks for the suggestion! Can confirm. Going down to 6.11.0 resolves the issue, going back up to 6.12 breaks it again. @voyula - logs are empty/non-existent.

[voyula]

I think output buffering a problem for downloading data.

I was say. https://github.com/laravel/framework/pull/31163#issuecomment-575772897

[driesvints]

We've reverted the pr that caused this.