Framework: Eloquent Builder doesn't allow Mixins

Created on 18 Apr 2019 · 6Comments · Source: laravel/framework

Laravel Version: 5.8.12
PHP Version: 7.2.15
Database Driver & Version: MySQL (what do you mean by version? MySQL 5.7.25? mysqlnd 5.0.12-dev?)

Description:

Eloquent Builder allows macros but doesn't allow mixins:

In ForwardsCalls.php line 50:

  Call to undefined method Illuminate\Database\Eloquent\Builder::mixin()

Steps To Reproduce:

Try adding a mixin within a service provider: \Illuminate\Database\Eloquent\Builder::mixin(new \App\Mixins\SearchRelationship);

Source

mikemand

Most helpful comment

Any update on this? or any reason that why eloquent\builder doesn't support mixins?

A-H-Pooladvand on 21 Oct 2019

👍3

All 6 comments

Heya, thanks for submitting this.

This seems like a feature request or an improvement. It's best to post these at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework. Please only use this issue tracker to report bugs and issues with the framework.

Thanks!

driesvints on 19 Apr 2019

@driesvints,

I was under the impression that the Macroable trait provided the mixin functionality too. Would this not be a bug? Eloquent's Builder gets its macro ability from the base Query Builder (via ForwardsCalls), so the mixin ability should also be present.

mikemand on 19 Apr 2019

@mikemand

You could always do something like this:

Builder::macro('mixin', function ($mixin) {
   $methods = (new ReflectionClass($mixin))->getMethods(
      ReflectionMethod::IS_PUBLIC | ReflectionMethod::IS_PROTECTED
   );

   foreach ($methods as $method) {
      $method->setAccessible(true);

      Builder::macro($method->name, $method->invoke($mixin));
    }
 });

Builder::mixin(New YourMixins);