Framework: Macro on \Illuminate\Database\Query\Builder always returns $this

[Vasiliy-Bondarenko]

• Laravel Version: 5.5.19
• PHP Version: 7.1

Description:

macro on Builder

\Illuminate\Database\Query\Builder::macro("toSqlWithBindings", function(){
            $sql = $this->toSql();
            foreach($this->getBindings() as $binding)
            {
                $value = is_numeric($binding) ? $binding : "'$binding'";
                $sql = preg_replace('/\?/', $value, $sql, 1);
            }
            return $sql;
        });

usage:

        dd(User::select('*')->toSqlWithBindings());

returns instance of Builder instead of sql string as expected.
is it intentional or am I making something wrong?

[themsaid]

You need to register the macro on the Eloquent service provider if you want to use it like this, so yeas you might end up having two versions of the same macro one for the Query builder and another for the Eloquent builder. This is by design.

[Vasiliy-Bondarenko]

@themsaid I made it work fine like this - please check it out. I think it's worth including in the core. What do you think? It works similar to dump() and dd() on Collection chain.
I can make a PR if it's worth it.

[larsnystrom]

For others having this problem like me:
What themsaid is saying is that you need to do \Illuminate\Database\Eloquent\Builder::macro() instead of \Illuminate\Database\Query\Builder::macro(), or possibly both.