Framework: php artisan preset none doesn't remove bootstrap-sass from bootstrap.js

Created on 4 Sep 2017  路  2Comments  路  Source: laravel/framework

  • Laravel Version: 5.5.0
  • PHP Version: 7.1.6
  • Database Driver & Version: MySQL

Description:

php artisan preset none removes most of bootstrap from the project, but not the reference to bootstrap-sass in the resource/assets/js/bootstrap.js.

Steps To Reproduce:

  1. Download fresh copy of Laravel.
  2. Run php artisan preset none.
  3. Run npm install
  4. Run npm run dev
  5. See error.

Most helpful comment

That's a pretty bad implementation then. php artisan preset none only gets the job half done, unless you don't mind seeing the same "Can't resolve bootstrap-sass" error every time you make a change to a Sass or JS file.

All 2 comments

See https://github.com/laravel/framework/pull/19618
The try/catch is there so that bootstrap.js doesn't have to be updated.
That pr was reverted to keep it there.

That's a pretty bad implementation then. php artisan preset none only gets the job half done, unless you don't mind seeing the same "Can't resolve bootstrap-sass" error every time you make a change to a Sass or JS file.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

iivanov2 picture iivanov2  路  3Comments

klimentLambevski picture klimentLambevski  路  3Comments

Fuzzyma picture Fuzzyma  路  3Comments

SachinAgarwal1337 picture SachinAgarwal1337  路  3Comments

PhiloNL picture PhiloNL  路  3Comments