Foundation-sites: Default <button> cursor should be configurable via _settings.scss

[brentdodell]

Should default cursor be a pointer (or a value configurable by _settings.scss), indicating that the button is clickable?

How to reproduce this bug:

Hover over a <button> element.

What should happen:

Default cursor should be a pointer (or a value configurable by _settings.scss), indicating that the button is clickable.

What happened instead:

cursor CSS is not set, defaulting to auto and displaying an arrow.

Browser(s) and Device(s) tested on:

Chrome on OSX

Foundation Version(s) you are using:

6.4.1, XY Grid

Test case link:

https://codepen.io/brentdodell/pen/WOgaov

[IamManchanda]

Default cursor should be a pointer (or a value configurable by _settings.scss), indicating that the button is clickable.

:+1:

[IamManchanda]

Thanks @brentdodell ... Added a safe PR #10367

[brettsmason]

Not sure if this is advisable or not - a quick search seems to suggest a button shouldn't have a pointer, eg: https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b

[IamManchanda]

@brettsmason I didnt add pointer ... i just added and binded cursor: auto into a variable if anyone wants to change it!
That being said ... i think we can consider cursor: default too

[brettsmason]

@IamManchanda Yeah no problems just wanted to flag up that its generally not best practice to set to pointer that's all, and that was the original question 😄

[IamManchanda]

@brettsmason default or auto ??

[brettsmason]

@IamManchanda Looks like auto is the default, so I'd go with that.

[brentdodell]

Thank you both @IamManchanda & @brettsmason.

I understand that it may not a best practice, but it seems many people do it (Foundation buttons even do it) and I do think it would be useful to have it in the settings.

Also, @brettsmason I do not say this to contradict you, but I found it humorous that the article you linked to had a button at the bottom of the page that was styled with cursor: pointer;.

Thanks again to you both!

[brentdodell]

@IamManchanda Yeah no problems just wanted to flag up that its generally not best practice to set to pointer that's all, and that was the original question 😄

I wasn't aware of that. Thank you!

[brettsmason]

@brentdodell Ha that's great irony right there, thanks for pointing it out 😄
You are right though, no harm in having it configurable 👍