Foundation-sites: Accordion Menu -- 'aria-multiselectable' is not an allowed attribute for aria role 'menu'

[ctcpip]

The accordion menu adds role="menu" for the <ul> and adds the aria-multiselectable="true" attribute, which is not allowed for the 'menu' role.

See: https://www.w3.org/TR/wai-aria/states_and_properties#aria-multiselectable

[ctcpip]

relevant lines in code:

https://github.com/zurb/foundation-sites/search?utf8=%E2%9C%93&q=aria-multiselectable&type=

[IamManchanda]

Dang!!
cc @kball @Owlbertz

[IamManchanda]

@ctcpip An accordion is a tablist btw .... just that being used in menu.
Marius what do you think about this ??

[Owlbertz]

Refering to my comment for a pending PR, in my opinion menu is the wrong role for that case. If tree would be used as I suggested, aria-multiselectable would be working as intended.

[IamManchanda]

In that case @kball .... Shall we make a point fix for 6.3.2 if that PR and suggestion will take some time??

[rafibomb]

6.4 is the next release - so it would be best to make this a separate update to use the role="tree"

@Owlbertz Are you able to submit this as a PR against the develop branch?

[Owlbertz]

Yeah.

[rafibomb]

Sorry - @IamManchanda has it right - for the 6.3.2 release since it's not a breaking change

[ctcpip]

Wow. Awesome response time! Looking forward to the fix. Didn't want to submit a PR because there are different ways to resolve this. Thanks everyone.

[IamManchanda]

Thanks @ctcpip
Yes We are Yetis and Yetis are awesome! :wink:

---

Update: Fixed in #10064

[rafibomb]

PR merged thanks @Owlbertz !

@ctcpip Thanks for the report and No worries - you can submit a pr and we'll offer suggestions or you can offer a suggestions and we'll guide you!