Foundation-sites: [Tabs] inconsistent use of active class

[aldees]

The Tab component use .is-active, however the Menu component use .active

Need consistent naming of 'active' class. I had a scenario where i needed to toggle the active state of both a tab and menu item at the same time. But, because they use different classes for active, I had to it in two lines instead of one. Please, update the Tabs component to use 'active' instead of 'is-active'.

Example:
$('my-tab-item, my-menu-item').toggleClass('active');

instead i had to split it up:
$('my-tab-item').toggleClass('is-active');
$('my-menu-item).toggleClass('active');

[kball]

I think we should actually move everything to .is-active, as these are state classes. Would accept a PR moving menus to .is-active.

[jmp1548]

Is this still an open issue? I can look into correcting it.

[IamManchanda]

I can look into correcting it.

@jmp1548 .... Sure, why not!

& incase If you are new to git & github or pull requests
This guide would help you for the same!
=> https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/

[colin-marshall]

I believe @jmp1548 took care of this with #9757, so I'm going to close this out.