Foundation-sites: [Reveal] Issues with Multiple Reveal Modals

[bflol]

How can we reproduce this bug?

Open multiple reveal modals so one is displayed in front of the other.

Case 1: Click outside both modals and press the escape key. Both modals are closed instead of just one.
Case 2: After the page loads, press the escape key to close the first modal. Then click outside the second modal and press escape. Nothing happens.
Case 3: Close the first modal.

What did you expect to happen?

Case 1: I expected only the top modal to close.
Case 2: I expected the second modal to close.
Case 3: I expected the is-reveal-open class to remain on the body.

What happened instead?

Case 1: Both modals were closed.
Case 2: The second modal did not close. The keydown.zf.reveal event was removed from the window object after the first modal was closed.
Case 3: The is-reveal-open class was removed from the body.

Test case:

http://codepen.io/anon/pen/Mbzydx

[ncoden]

I looked from where the problems come from but I do not know the Reveal and ZF Js enough to solve this issue.

• Case 1: We must remember the "front" Reveal (the latest opened) and close only it at js/foundation.reveal.js:317.
• Case 2: We stop listening on ESC pressing at js/foundation.reveal.js:394 when the first modal is closed.
• Case 3: Case 2: We remove the class from body at js/foundation.reveal.js:406 when the first modal is closed.

Codepen with ZF 6.3.0

@brettsmason I will need your help on this ;)

[ncoden]

@brettsmason Would you have some time to take a look at this issue ?

[brettsmason]

@ncoden sorry missed this. I'll try and take a look later, though it may require someone with more JS skills

[ncoden]

Ah sorry, I had you in mind for the Reveal, I probably mistaken it for Off Canvas. 🤔

[brettsmason]

Just had a quick look - I think this will require a JS person, sorry 😄
Yeah could probably of helped it was off canvas 😉

[DanielRuf]

@kball do you still plan to work on a solution?