Foundation.mozilla.org: PNI mailto: issue

Created on 26 Oct 2019  路  6Comments  路  Source: mozilla/foundation.mozilla.org

Describe the bug
On the PNI site, some of the links on the product pages under "How to contact the company: Email section" direct to a mailto: when it should just lead to the company website with their contact information. e.g. The Nintendo Switch page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://foundation.mozilla.org/en/privacynotincluded/products/nintendo-switch/
  2. Scroll to "How to contact the company"
  3. Under the Email Section, click the link
  4. See error

Expected behavior
A mailto: can happen if we have the company email directly listed on our site, but if it is a site link that directs to a product's company about page, we need it to change to direct to the new site in a new tab.

Screenshots
Screen Shot 2019-10-26 at 11 29 01 AM

Screen Shot 2019-10-26 at 11 29 09 AM

Buyer's Guide 馃泹 QA engineering

Most helpful comment

ah very cool!

All 6 comments

Jen can manually add "mailto:" via the CMS for cases were we do have an email address. So for devs, please remove the automatic "mailto:" from the email field.

@kristinashu as an alternative, I've added an email verification check below the email text field. If this box is checked, it will automatically add the mailto: to the link without altering the on-screen text :)

Screen Shot 2019-11-05 at 11 13 59 AM

ah very cool!

@youriwims @kristinashu So do we have to go back in and fix each mail to? I still get the mail client pop up for the [Switch] even though it's a link.(https://foundation.mozilla.org/en/privacynotincluded/products/nintendo-switch/).

The changes aren't on prod yet, just in the pr that I requested your review on #3845 馃槣 But, yes, _sorta_.The default link is set to 'no email'/no mailto:, so once the pr lands, you just have to update the products with actual emails and check the _Email Verification_ box.

It's good the default is _no email_ since most of them products have a url instead of an actually email address. And Jen is mentally prepared to go through and update these once it is on prod.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kristinashu picture kristinashu  路  5Comments

kristinashu picture kristinashu  路  5Comments

taisdesouzalessa picture taisdesouzalessa  路  3Comments

alanmoo picture alanmoo  路  3Comments

taisdesouzalessa picture taisdesouzalessa  路  5Comments