Fosuserbundle: Avoid Salt generator when using encoders like Bcrypt

[runcom]

This is not a big issue but FOSUserBundle generates and store in db the salt when i use my own Bcrypt encoder but bcrypt doesn't need a salt to be persisted so it's useless

[flip111]

Good suggestion. Right now after a doctrine:schema:update i have to manually have to change the salt column to allow null values. I have not been able to override the salt property in any way in the Doctrine ORM. It's said that it should be possible with listeners to the onLoadMetadata event. But it's still a violation in OOP. I have not tried with the listeners yet. For now i just manually change salt to allow null = true in my schema.

[stof]

Something like this should do the trick:

namespace Acme\DemoBundle\Entity;

use FOS\UserBundle\Model\User as BaseUser

/**
 * @ORM\AttributeOverrides({
 *     @ORM\AttributeOverride(name="salt", column=@ORM\Column(nullable=true))
 * })
 */
class User extends BaseUser
{
    // ...
}

[flip111]

You would think so ... however that's one of the options i have exhausted.

[boogerlad]

in /vendor/friendsofsymfony/user-bundle/FOS/UserBundle/Model/User.php:
remove all instances of salt and change function like so

public function getSalt()
{
    return "";
}

empty strings are good since they evaluate to false in php so it won't get added as a salt parameter for bcrypt so automagic salt generator gets invoked.

vendor/friendsofsymfony/user-bundle/FOS/UserBundle/Resources/config/doctrine/model/User.orm.xml
remove salt field.

[core23]

IMHO we can't fix this, because the symfony encoder method expects a valid salt.

[flip111]

@core23 where exactly in the code of FUB is the coupling between the user model and the symfony encoder?

[core23]

Here https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/Model/UserManager.php#L161-L168