Fosrestbundle: JMSHandlerRegistry must implements HandlerRegistryInterface correctly

Created on 10 Nov 2018 · 4Comments · Source: FriendsOfSymfony/FOSRestBundle

Hello all,

In the latest version of JMS\Serializer the class JMS\Serializer\Handler\HandlerRegistryInterface defines registerSubscribingHandler and registerHandler as void functions thus JMSHandlerRegistry implementation must follow the same definition and not return anything.

public function registerSubscribingHandler(SubscribingHandlerInterface $handler): void;
public function registerHandler(int $direction, string $typeName, string $format, $handler): void;

versus

 /**
 * {@inheritdoc}
 */
public function registerSubscribingHandler(SubscribingHandlerInterface $handler)
{
    return $this->registry->registerSubscribingHandler($handler);
}

/**
 * {@inheritdoc}
 */
public function registerHandler($direction, $typeName, $format, $handler)
{
    return $this->registry->registerHandler($direction, $typeName, $format, $handler);
}

Can anyone fix this?

Thanks for the help.
Timothée

Source