Forgottenserver: Missing item attribute for distance weapons?

[nekiro]

Actual behaviour

We have this bow.

<item id="2456" article="a" name="bow">
        <attribute key="weight" value="3100" />
        <attribute key="weaponType" value="distance" />
        <attribute key="slotType" value="two-handed" />
        <attribute key="ammoType" value="arrow" />
        <attribute key="skilldist" value="3" />
        <attribute key="range" value="6" />
    </item>

when we add "ammoType" then it doesnt show skill dist in description:
16:57 You see a bow (Range:6).
else after removing only this attribute it shows "distance fighting +3"
16:58 You see a bow (distance fighting +3).

Expected behaviour

It should show item attribute everytime

[Kamenuvol]

I can confirm it in game and looking sources.
When you have ammo type, you enter here:
https://github.com/otland/forgottenserver/blob/master/src/item.cpp#L871
and this part does not read skills attributes.

Otherwise, it enters in:
https://github.com/otland/forgottenserver/blob/master/src/item.cpp#L893
and here it read skills attributes.

[ranisalt]

Since there are no weapons on Tibia that grant a skill bonus it was just ignored. What do you expect to show?

[Kamenuvol]

Actually, we already have, they were introduced in 10.94 version that TFS does not have now.
www.tibiawiki.com.br/wiki/Crossbow_of_Mayhem_(Overcharged)

[nekiro]

As @Kamenuvol said.
Next item that use this is Umbral Master Crossbow, +3 dist.

[Kamenuvol]

oh yeah, @thexamx, I forgot the umbral items from 10.30, I believe we already have it in items.xml

[darkjav]

@Kamenuvol I look on items.xml and not there, and when i try add it to xml, only not work.
Yes applied the value to the skills, but not show the description.
Is necessary edit the source, specifically in item.cpp

EDIT:

In https://github.com/otland/forgottenserver/blob/master/src/item.cpp#L1065
maybe add:

http://pastebin.com/URbU3jKH

I dont know if work it, i need go to my home and test it.

[ranisalt]

Hm, that's new to me hahah gonna take a look.

[malucooo]

the fix it's here
replace ur item.cpp for this:

http://pastebin.com/bN8CwNk7

[mattyx14]

omg

[darkjav]

@malucooo Thanks alot!

[nekiro]

@malucooo
Please edit your post and post link to pastebin.
Also you could post only the solution not whole file XD

I will wait for official info, I wont trust you.

[GoularPink]

Can someone make a pull request please?