Foreman: Export To Systemd

[jasonivers]

When I have a .env file, foreman is ending up with ExecStart on the Environment line, like this:

Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games" "RAILS_ENV=uat" "RACK_ENV=uat" ExecStart=/bin/bash -lc 'bash -lic 'bin/sidekiq''

This breaks restarting it. It should be:

Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games" "RAILS_ENV=uat" "RACK_ENV=uat" ExecStart=/bin/bash -lc 'bash -lic 'bin/sidekiq''

[timurb]

@jasonivers I think you've mistyped the "it should be" part.
It should be something like the following instead (at least it was like that in my setup with foreman 0.82):

Environment=PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Environment=RAILS_ENV=uat
Environment=RACK_ENV=uat
ExecStart=/bin/bash -lc 'bash -lic bin/sidekiq'

I see exactly the same issue for the few recent days.

[timurb]

I guess this commit introduced regression: https://github.com/ddollar/foreman/commit/c7edf6490b6ccf02df2de9e03d76b1fb1a8df63b

No idea if this one contributed to that too: https://github.com/ddollar/foreman/pull/652

[ddollar]

Anyone up for writing a patch and a test case so this doesn't regress again?

[timurb]

I can take a look. Any idea how to write a test for this?

24 янв 2017 г. 6:19 PM пользователь "David Dollar" [e-mail]
написал:

Anyone up for writing a patch and a test case so this doesn't regress
again?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ddollar/foreman/issues/664#issuecomment-274833645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM0GVdz0Fk6Y-QUAJtxb8W1mCW6omEuks5rVhabgaJpZM4Lpw7E
.

[yelhouti]

Thanks guys for the great work, you might want to remove the gem 0.83 since you removed the release from git

[dunyakirkali]

When can we expect this to be released?

[jasonivers]

Thank you for coding the fix... will it be released any time soon?

[rilian]

thank you so much 👍