Fontbakery: Vendor ID warning & reporters to explain result level

[lettersoup]

Fontbakery warns that my Vendor ID is not known registered id. And it should have a 4 character code. Actually a lot of Vendor ID has 2 character codes. And my id: LS is registered. Could you advise?

[m4rc1e]

Was your vendorID added recently?

When I check our cached vendor list, https://github.com/googlefonts/fontbakery/blob/master/Lib/fontbakery/data/fontbakery-microsoft-vendorlist.cache, I can see LS isn't there.

@felipesanches perhaps we also need to strip the trailing spaces from font vendorIDs? I understand that a font vendorID is meant to be four characters long. However, I think the MS list removes these spaces since it's html.

[lettersoup]

Hi Marc,
yes its added recently.

[m4rc1e]

Ok cool. I guess your vendorID will be included in the next fontbakery update. For the time being, please ignore this check.

Also, checks which produce a warn are not fatal. Think of them as alerts that something may not be quite right.

[lettersoup]

Cool! Many thanks!

[davelab6]

@felipesanches please don't close this after confirmation of the latest update fixing this vendor ID. The the first step. But the fact that the meaning of the return levels isn't clear should also be addressed, so please keep this issue open and propose a way to address this in the various reporters :)

[felipesanches]

my proposal is to say that the ID was not yet recognized, but if the user can see it listed on microsoft's website, then it is all fine.

[felipesanches]

Our code-tests have a set of test-cases whith examples of good and bad vendor IDs. As you can see here, 2-char IDs are OK, but with some caveats:

[felipesanches]

I've just updated the list of vendor IDs and it includes LS for LetterSoup:

[laerm0]

@felipesanches I've got a plus sign in mine - M+F - just in case you want another weird glyph to allow. 😜

[felipesanches]

@felipesanches I've got a plus sign in mine - M+F - just in case you want another weird glyph to allow. 😜

I believe that one is already considered good. Let me know if you ever see a legitimate one that is not accepted.

[lettersoup]

@felipesanches Many thanks!

[felipesanches]

You're welcome! :-)