Font-awesome: Include version in top of CSS file again?

[henrik]

Hi! Recently upgraded from 5.0.13 to 5.6.3. Not using any kind of dependency manager for Font Awesome, just copying files into the project.

5.0.13 included the version number in a comment at the top of all.css, and 5.6.3 didn't.

I liked how I could easily look up the version in the file to determine which icons are available to me, and I liked that the diff clearly showed the old and new version when upgrading.

I can add it in manually, of course, but could there be a point to putting it back in the distributed files also?

[tagliala]

Hi!

Thanks for being part of the Font Awesome Community and thanks for reporting this.

5.0.13 included the version number in a comment at the top of all.css, and 5.6.3 didn't.

I can see the license information on each one of:

• all.css https://github.com/FortAwesome/Font-Awesome/blob/master/css/all.css#L2
• fontawesome.css https://github.com/FortAwesome/Font-Awesome/blob/master/css/fontawesome.css
• fontawseom.min.css https://github.com/FortAwesome/Font-Awesome/blob/master/css/fontawesome.min.css

but the downloadable zip bundle for version 5.6.3 does not contain them.

The license header is present in the 5.6.1 bundle, so I think there is a regression somewhere in the build system

@robmadole could you please take a look ?

[tagliala]

@henrik Seems fixed in the freshly released 5.7.0. Could you please check?

[tagliala]

Well, I'm going to close here but feel free to comment

[henrik]

Thank you! I tried downloading it again (https://origin.fontawesome.com/releases/5.7.0/web/download when logged in) and it seems it's not at the top of all.css:

$ head -n 5 fontawesome-pro-5.7.0-web/css/all.css
.fa,
.fas,
.far,
.fal,
.fab {

[tagliala]

@henrik I can confirm, but this is related to Font Awesome Pro now

Could you please open this issue @ https://github.com/FortAwesome/Font-Awesome-Pro ?

[henrik]

Ah, sorry, didn't realise I should open the issue in another repo.

I get a 404 – I suppose I don't have access to that repo. Could I ask
someone else with access to open an issue?

On Tue, Jan 29, 2019 at 7:18 PM Geremia Taglialatela <
[email protected]> wrote:

@henrik https://github.com/henrik I can confirm, but this is related to
Font Awesome Pro now

Could you please open this issue @
https://github.com/FortAwesome/Font-Awesome-Pro ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FortAwesome/Font-Awesome/issues/14518#issuecomment-458670431,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAA2MPHHuJ2pfDGkO4-f7-zcuObwiZ1ks5vIJ6VgaJpZM4aIPXm
.

[tagliala]

@henrik if you are a pro user you should have access to that repo

Please check that you have linked your Font Awesome Account to your GitHub account at https://fontawesome.com/account/services

[tagliala]

Reopening here, this issue came back on 5.7.1 and it also affects JS files

[robmadole]

Ok, I think I see what the issue was. This should be fixed in 5.7.2. We'll see 🤞

[tagliala]

Still an issue in 5.7.2 (Pro-Free-CDN / CSS-JS) :\

[robmadole]

$%^&*! Ok, @tagliala can you give me a link to a file that _should_ have the header and doesn't? (Sorry for being dense here)

[tagliala]

@robmadole

css and js files in the downloadable zip bundles (both font awesome pro and free)

• https://github.com/FortAwesome/Font-Awesome/releases/download/5.7.2/fontawesome-free-5.7.2-web.zip ❌ (same for FA Pro)
• https://github.com/FortAwesome/Font-Awesome/releases/download/5.7.1/fontawesome-free-5.7.1-web.zip ❌
• https://github.com/FortAwesome/Font-Awesome/releases/download/5.7.0/fontawesome-free-5.7.0-web.zip ✔️ CSS ❌ JS
• https://github.com/FortAwesome/Font-Awesome/releases/download/5.6.3/fontawesome-free-5.6.3-web.zip ❌
• https://github.com/FortAwesome/Font-Awesome/releases/download/5.6.1/fontawesome-free-5.6.1-web.zip ✔️

CDN:

• https://use.fontawesome.com/releases/v5.6.1/css/all.css ✔️
• https://use.fontawesome.com/releases/v5.6.1/js/all.js ✔️
• https://use.fontawesome.com/releases/v5.6.3/css/all.css ❌ (and newer)
• https://use.fontawesome.com/releases/v5.6.3/js/all.js ❌ (and newer)

[robmadole]

Thanks @tagliala that helps. We aren't going to be able to change the older versions but I'll try to get this really fixed before the next version is released.

[robmadole]

OK, I've verified that this is at least fixed in 5.8.0. We aren't going to be able to fix the older ones but I think I've fixed the root cause that was responsible for this.