Folium: Plugin SemiCircle

[syberworld]

Hi,
I have try to made port plugin for Semicircle.
I'm newbe and I hope it's full working.
We can see it here
This is a preview:

Thank you for your job, it's a very beutifull.

[ocefpaf]

The code looks really nice! If you want you can send a PR to https://github.com/python-visualization/folium/tree/master/folium/plugins adding that to folium directly.

[syberworld]

Oh, great, thank you.
I try to add.
I must change __init__.py too ?

[ocefpaf]

I must change __init__.py too ?

Yep. You'll want to import it there and add the the __all__ list like the others.
We can guide you more on the PR itself.

[syberworld]

Yes, I need some help, it's my first time.

[ocefpaf]

Yes, I need some help, it's my first time.

I sent 100ths of PRs and I always need help :smile:

Don't worry. We'll do our best to guide you along the way. (Ping @Conengmo who is a wonderful reviewer!)

How comfortable are you forking folium, creating a branch, and submitting a PR?

GitHub docs are a pretty good source of info: https://help.github.com/articles/creating-a-pull-request-from-a-fork/

[syberworld]

Ok, I study it and I will try

[ocefpaf]

Ok, I study it and I will try

Feel free to ask anything along the way.

[syberworld]

I think I have add it .... I hope

[syberworld]

Hi @Conengmo, it's ok or I wrong something ?

[Conengmo]

We'll continue the discussion in the related PR: #1000

[Conengmo]

This has been merged: https://github.com/python-visualization/folium/pull/1238