Focus-android: Close tab button

[dimqua]

Please add a possibility to close a tab on a tabbar by using close button.

[codebu5ter]

Currently, there's no way to close an individual tab, but to repeatedly press the back button until it closes. I've implemented a more user-intuitive way, in which the user just has to long press the tab and it will be closed.

Also, the process of closing all tabs requires two clicks at the moment. I've implemented the same functionality to close all tabs, in which the floating action button needs to be long pressed to close all tabs, which is more user-intuitive.

[Benestar]

Instead of long pressing, I would rather implement some mechanism to swipe the tab away which seems to be more intuitive and consistent with material design guidelines (compare eg. the Gmail App). Also, in Firefox Mobile on Android, you can swipe a tab away to close it.

[bbinto]

Adding this to the [meta]

[pocmo]

@lime124 @antlam We have a contributor PR that implements "swipe-to-dismiss" for tabs. Is this something we are interested in? Managing single tabs has been debated a lot in the past.

[antlam]

@pocmo I'm going to leave this to @lime124

But since this is a P5, I worry it could be kind of messy if we start pulling at this thread. This interaction on top of the expanded FAB isn't something that is very standard in Android and just feels a bit weird to me (versus say, simply an X button).

[lime124]

I agree with @antlam - i also worry about the ripple effects this could potentially have without a lot more investigation to make sure all the i's are dotted so to speak.

[asafh]

Hi,
I've implemented (mozilla-mobile/focus-android#4309) a swipe to dismiss over the new (kotlin) codebase. I believe the interaction feels natural for android.
Should I do anything to get this reviewed or just wait patiently?

[ekager]

Hi @asafh ! Thank you for wanting to contribute but we currently don't have the bandwith on our team to accept feature patches for Focus. Please check out one of our other projects if you want to get involved:
https://github.com/mozilla-mobile/android-components
https://github.com/mozilla-mobile/fenix

[asafh]

Hi @ekager, that's unfortunate but no worries. I'll look into supporting my focus use case within fenix.

Cheers