Focus-android: [ux] UI audit of dialogs/ context menus in app

[antlam]

Noticing that we're not actively keeping track of the UI here. So I'm filing this to keep things polished and in order. Strictly looking at some padding, color, and type consistencies here. Nothing major.

Moved checklist to eng [meta]: #1659.

[bbinto]

UX: S
Eng: S

[antlam]

Top new, Bottom old. For comparison

Note: Share on top is the press-state example

[antlam]

@pocmo should be the last of it!

[layely]

@antlam @bbinto @lime124 is this something that i can work on ?

[lime124]

hey @layely! Are you interested in contributing as a designer or an engineer?

If it's the design side, there are designs posted for this issue but I can totally point you to other issues that need design work.

If it's engineering, @pocmo would be a better person to ping for what things you should work on.

Thanks for the ping! :)

[layely]

Thank you for your reply @lime124. Sure the engineer side is what I am interested to. Let's see if @pocmo has something to suggest doing here.

[pocmo]

@layely Yes, help would be appreciated here. Currently this tracks the current milestone to be released with the next version of Focus. So there's some time pressure. Therefore I'd suggest to create small commits that fix only a specific thing and open separate pull request for them. This way we can merge them separately (and early) and someone can potentially take over later. If you try to fix all of that in a gigantic pull request then this might take too much time (with review).

[bbinto]

awesome, thanks @layely

[layely]

The first is my capture when I apply changes suggested by @antlam
The second is @antlam capture

But after applying #009688 color (100%) to buttons ADD and CANCEL, I noticed that their colors differ from @antlam capture. Is there something that I missed here?

It would be great also if you can give the opacity that you used for the text on the edit_text.

[mcomella]

@antlam Additionally, what's the hint text color? It says #FFFFFF in the mock, but it's definitely not white. :)

[lime124]

@mcomella it's white with a 40% opacity which will get you that greyish color.

@layely i think that might be the wrong value. try this one: 0A84FF. I'm not sure which text you mean by "edit text". Is that the "Scene.ca" in the mock? That looks like it's #fffff with a 70% opacity. Can you give that a go?

Thanks so much guys!

[layely]

@layely i think that might be the wrong value. try this one: 0A84FF. I'm not sure which text you mean by "edit text". Is that the "Scene.ca" in the mock?

Yes it is. Thank you @lime124

Can you give that a go?

Ok I will post a screenshot here soon.

[antlam]

@layely i think that might be the wrong value. try this one: 0A84FF. I'm not sure which text you mean by "edit text". Is that the "Scene.ca" in the mock?

Yes it is. Thank you @lime124

Actually this is spec'd out correctly in product already. I didn't spec it here because it doesnt need to be changed. Sorry for the confusion!

[liuche]

@mcomella During Sprint planning, we're going through the P2 list. Is this checklist up to date, and could you give a status update?

Relatedly, we can think about how to keep track of contributor work - whether it's enough to give verbal updates, or if we need to comment in Issues, etc.

[mcomella]

During Sprint planning, we're going through the P2 list. Is this checklist up to date, and could you give a status update?

Sorry this was confusing – this issue is from before we changed our Sprint process. I made this the [ux] bug and created a corresponding eng [meta] bug (#1659) with broken out bugs. I made sure that checklist is up-to-date and applied no labels.

Relatedly, we can think about how to keep track of contributor work - whether it's enough to give verbal updates, or if we need to comment in Issues, etc.

If we break up issues as we agreed to, I think there will generally be comments from contributors in the issue or at least a single, clear PR we could follow. I think this bug is confusing because all the conversations are happening in PRs and checklists don't have a reference to the commit that closed them so it's unclear if they're actually closed or not.

I think the biggest issue with contributors is a clear indication of who a bug is assigned to (and following up to make sure they're still working on it), though I've seen bots for this if we wanted to invest.