Focus-android: Invalid icons of share buttons on Nytimes video section

[sv-ohorvath]

Devices:
Huawei Honor 8 (Android 6.0)
Samsung Galaxy Note 4 (Android 5.0.1)
build: Focus 1.1. Beta Build #2202

Steps to reproduce:

1. Open Focus and go to nytimes.com/video.
2. Scroll down to see the share buttons under each video.

Expected results:
The sharing icons are displayed.

Actual results:
There are invalid icons under the video titles. See screenshot:

[nojunpark]

I actually saw this as well in www.thestar.com site occasionally. (It shows chinese character instead of a graphical icon). This goes away when I reinstall the app, and it's not clear when the icon gets replaced with asian chars.

[pocmo]

What trackers are you blocking in settings? This is often caused by blocking web fonts.

[nojunpark]

Icons that gets replaces with asian chars are usually social media icons (facebook, twitter, etc.) and I just confirmed that blocking web fonts causes it on thestar.com. (perhaps a warning would be nice?)
EDIT: oh wait, it already have the warning.

[pocmo]

Yeah. There's also #834 for improving the explanations.

[sv-ohorvath]

Turned off all trackers in Settings and this still occurs.

[nojunpark]

hmm, sv-orhorvath is right, this is different from thestar.com issue. chinese chars show when web font blocking is disabled.

[pocmo]

Oh, right. And it doesn't happen on Chrome.

[mcomella]

I think the problem is we're blocking cookies: I can reproduce on Chrome with cookies disabled.

[nojunpark]

on iOS, it just doesn't display anything where icons should be- we should file a mirror bug in iOS as well

[ekager]

I fixed this by enabling dom storage in settings in WebViewProvider. Is this something that we would want to do in general? Not sure what else dom storage is used for, but I assume we clear it with WebStorage.getInstance().deleteAllData() ?

[ekager]

Here's some more information I found about dom storage API. I am not sure if there are any security concerns or extra steps in addition to WebStorage.getInstance().deleteAllData() we would have to take to clear storage after the session.

https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API
http://viralpatel.net/blogs/introduction-html5-domstorage-api-example/

[pocmo]

@ekager I wrote an automated test to make sure we are clearing the session store after every session (Set you as a reviewer). This test passes with your patch: We store and keep the value and remove it after the session has been erased. Can you create a PR for your patch? :)

[pocmo]

Merged!